Skip to content

Redirect to //README.md when clicking edit from repo home #34188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SpeedyCraftah opened this issue Apr 13, 2025 · 3 comments · Fixed by #34189
Closed

Redirect to //README.md when clicking edit from repo home #34188

SpeedyCraftah opened this issue Apr 13, 2025 · 3 comments · Fixed by #34189
Labels
Milestone

Comments

@SpeedyCraftah
Copy link

Description

I'm not sure if this was reported or fixed already, or if this is expected behavior, but I am running the latest Docker rootless Gitea at the time of writing (1.23.6 built with GNU Make 4.4.1, go1.23.7 : bindata, timetzdata, sqlite, sqlite_unlock_notify), and when I click to edit the README.md from the repo home page, it redirects me to _edit/master//README.md instead of _edit/master/README.md like it would when pressing the edit button inside of the README file, I believe this caused me issues in earlier Gitea versions where my changes wouldn't save properly, but it looks like this doesn't happen anymore in the latest version. This happens on different repositories.

Happy to try and submit a PR on my own if needed, I want to confirm whether this is an actual bug or not first.

Gitea Version

1.23.6

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

From repo home page (with the issue):
Image

From README file context:
Image

Git Version

No response

Operating System

No response

How are you running Gitea?

Self hosted rootless container using Podman

Database

SQLite

@wxiaoguang
Copy link
Contributor

-> Fix incorrect file links #34189

@wxiaoguang
Copy link
Contributor

Happy to try and submit a PR on my own if needed, I want to confirm whether this is an actual bug or not first.

Thank you very much 🙏 I just found that the problem is more complex than it looks, so need to refactor all related usages, so I proposed a refactoring PR.

@SpeedyCraftah
Copy link
Author

SpeedyCraftah commented Apr 13, 2025

Happy to try and submit a PR on my own if needed, I want to confirm whether this is an actual bug or not first.

Thank you very much 🙏 I just found that the problem is more complex than it looks, so need to refactor all related usages, so I proposed a refactoring PR.

Probably best to leave refactoring up to people that know the codebase much better than me 😅 thanks a bunch for the fix!

@lunny lunny closed this as completed in 34349c0 Apr 13, 2025
@lunny lunny added this to the 1.24.0 milestone Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants