Frontmatter summary icon is not displayed

[rijenkii]

Description

<summary> of the <details> tag which contains contents of the markdown frontmatter contains an <i class="icon table"> tag, but it does not render.

Example issue body:

---
this: is
a: yaml frontmatter
---
the `<summary>` of the `<details>` html tag above has element `<i class="icon table"></i>`, and it does not render.

Demo link: https://demo.gitea.com/rijenkii/123123/issues/1

Related code:

gitea/modules/markup/markdown/goldmark.go

Lines 229 to 230 in 6ed1b26

	// FIXME: the "icon xxx" is from Fomantic UI, it's really questionable whether it still works correctly
	err := r.renderInternal.FormatWithSafeAttrs(w, `<i class="icon %s"></i>`, name)

Possibly related code:

gitea/modules/markup/markdown/markdown.go

Lines 187 to 191 in 6ed1b26

	rc := &RenderConfig{
	Meta: markup.RenderMetaAsDetails,
	Icon: "table",
	Lang: "",
	}

Gitea Version

1.24.0+dev-529-g92dfec704f

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Git Version

No response

Operating System

No response

How are you running Gitea?

Demo

Database

None

[wxiaoguang]

Thank you for the detailed analysis! It seems to be a regression of the "removal of Fomantic font icon"

Will take a look.

[wxiaoguang]

-> Fix markdown frontmatter rendering #34102

Does it look good to you?

[rijenkii]

Yeah, it looks nicer than before.

List of keys is a nice touch, but I'm not sure how (and if) it will work with non-object frontmatters (however I am not sure they are supported at all):

---
- hello: world
  testing: lists
- and: frontmatter
  rendering: edgcases
---

They do seem completely broken rn (frontmatter yaml is pasted into the document body) (out of scope for this issue, can create another if this usecase is even supported):

[wxiaoguang]

List of keys is a nice touch, but I'm not sure how (and if) it will work with non-object frontmatters (however I am not sure they are supported at all):

Yes, there was a bug, they broke. New UI is still better in this case (at least, no serious broken):

Old UI

New UI