Skip to content

Broken parsing of Rust multiline Attribute Macros #33915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vpochapuis opened this issue Mar 17, 2025 · 4 comments
Closed

Broken parsing of Rust multiline Attribute Macros #33915

vpochapuis opened this issue Mar 17, 2025 · 4 comments
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail

Comments

@vpochapuis
Copy link

Description

Issue encountered

While doing PR reviews I stumbled upon this bug in the Files Changed tab:

Image

The Attribute Macro (in Rust) which is spread over 2 lines is having the second line string text not being displayed in the same color as the previous part of the same string.

Why would we like to fix it

It seems it would be intended to have the same color for the same string in that Attribute Macro.

In Zed editor:

Image

In VsCodium IDE:

Image

System Info

OS: Debian
Gitea version: 1.23.5

Thank you for your time reading this~

Gitea Version

1.23.5

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Self-Hosted Debian based LXC using APT repository.

Database

None

@wxiaoguang
Copy link
Contributor

I think it should have been fixed by Full-file syntax highlighting for diff pages #33766 in 1.24 (which is main-nightly at the moment).

@wxiaoguang wxiaoguang added issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail and removed type/bug labels Mar 17, 2025
@vpochapuis
Copy link
Author

I think it should have been fixed by Full-file syntax highlighting for diff pages #33766 in 1.24 (which is main-nightly at the moment).

Ok great! Thanks for the fast answer!
Should we close this one? Can someone confirm this on 1.24?

@wxiaoguang
Copy link
Contributor

Demo site: https://demo.gitea.com/wxiaoguang/test-repo/pulls/3/files

And you could also deploy the main-nightly build https://dl.gitea.com/gitea/main-nightly/ in your environment, it should be stable enough for daily usage.

@vpochapuis
Copy link
Author

Demo site: https://demo.gitea.com/wxiaoguang/test-repo/pulls/3/files

And you could also deploy the main-nightly build https://dl.gitea.com/gitea/main-nightly/ in your environment, it should be stable enough for daily usage.

Ok great seems fixed! Thanks a lot for the help and the check!
I can close this then.

Thanks for the information about nightly builds, i will evaluate whether to switch or not!
Have a nice day~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail
Projects
None yet
Development

No branches or pull requests

2 participants