Open with <IDE> x-github-client expects full-uri

[Red3Tango]

Description

When setting up a custom "Open with " in Site Admin, web_src/js/features/repo-common.ts will encode the Repo's {url} to generate the href=. GitHub Desktop uses the x-github-client handler, and does not recognize encoded URLs.

Do not think this is necessarily a bug with Gitea or GitHub Desktop, and cannot expect a conditional for every client that may be out there. Would think something like {URL} be unencoded, and leaving {url} being encoded.

Gitea Version

1.23.4

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Running gitea-1.23.4-linux-amd64 from systemd on Debian 10.

Database

MySQL/MariaDB

[wxiaoguang]

Do you mean to use x-github-client:{url} as the "Open-with URL" and use the {url} directly without encoding?

[wxiaoguang]

Does " Improve Open-with URL encoding #33666 " look good to you?

• proto://a/{url} => proto://a/https://gitea
• proto://a?link={url} => proto://a?link=https%3A%2F%2Fgitea

[Red3Tango]

Yeah, I think that looks good. It doesn't add another 'variable', just formatting based on how the template is written (being either part of the URL itself, or Field that is passed).

[wxiaoguang]

1.23-nightly is ready (it is a stable release and will be 1.23.5)

• https://dl.gitea.com/gitea/1.23-nightly/
• https://hub.docker.com/r/gitea/gitea/tags?name=1.23-nightly