Syntax highlighting incorrect in Diff for PascalObject

[NeeeeB]

Description

There is a problem with colors and syntax highlighting in diff for PascalObject language (maybe other too, didn't try).
This is what the diff looks like :

As you can see, the 2 lines of comments (beginning with //) are not treated as comments.

The problem is not present in the code explorer where comments are properly detected :

Gitea Version

1.23.1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

package manager (Arch) so systemD

Database

None

[wxiaoguang]

The reason is this: #19684 (comment) and #21970

• Full file highlighting: guess the syntax by file content
• Diff highlighting: only use the file extension (then maybe it is rendered as traditional pascal but not object pascal) and highlight line by line

(Just a guess) maybe we could hard code all *.pas to use object pascal syntax as a workaround.

[wxiaoguang]

Hmm, it is a upstream bug: alecthomas/chroma#1042

[NeeeeB]

Yup, I was gonna reply that comments in Pascal and ObjectPascal are the same, //
Thanks for opening that issue in Chroma.

[silverwind]

Opened #33358 for discussing a general fix.

[wxiaoguang]

Opened #33358 for discussing a general fix.

This is another case than #33358 , this case could be fixed by upstream

[silverwind]

Yeah, that's why i left this open. A general solution with the full-file syntax highlight would also fix this issue assuming the file has more than one line and a trailing newline.

[wxiaoguang]

After Full-file syntax highlighting for diff pages #33766 , I think this issue could also be fixed, because there is always a new line after the comment.

Feel free to reopen if there is still any problem.