PHP Syntax Highlighting does not working in review mode

[dionisvl]

Description

Hello
PHP syntax highlighting does not working in Code-Review mode.
But i see that its works for TypeScript, Kotlin etc.

Current example on try.gitea.io:
https://try.gitea.io/den/test/pulls/1/files

Screenshots

Gitea Version

1.19.0+dev-135-gf047ee0a4

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Windows 10 Pro

Browser Version

Chrome 107

[lehag92]

Syntax highlight works on edit/view file page: https://try.gitea.io/den/test/src/commit/8877ea0e117b428f22e72ee3f2908603ef88182c/testphp2.php
but same changes in PR page does not highlighting.

[wxiaoguang]

IMO it's similar to this one: #19684 (comment)

When Gitea renders the diff page, it calls the syntax highlighter line by line, then the highlighter can not work properly.

Just my guess.

[lehag92]

Can syntax highlighter check at least file name extension and try to highlight it line by line?

IMO it's similar to this one: #19684 (comment)

When Gitea renders the diff page, it calls the syntax highlighter line by line, then the highlighter can not work properly.

Just my guess.

[wxiaoguang]

My guess is: the PHP syntax highlighter needs to see a <?php tag first to start colorizing the code, so it won't highlight the lines after <?php in diff mode, while other languages do not have such mechanism.

I haven't looked into the code. Just FYI.

[zeripath]

@wxiaoguang is right here.

I am fairly certain that the correct lexer will be being selected here - the issue is that without the lexer seeing the <?php it won't switch in to php mode. So it will simply call of this stuff "HTML"

Now, the only way to fix that would be to search backwards until you find the start of the block, which essentially requires one to lex the whole of the document and not just the fragment. Whilst that would be fine for small files it's not gonna work very nicely for big files.

[dionisvl]

@zeripath
ok, let's at least analyze all PHP files except > 1 MB

[lehag92]

@wxiaoguang is right here.

I am fairly certain that the correct lexer will be being selected here - the issue is that without the lexer seeing the <?php it won't switch in to php mode. So it will simply call of this stuff "HTML"

Now, the only way to fix that would be to search backwards until you find the start of the block, which essentially requires one to lex the whole of the document and not just the fragment. Whilst that would be fine for small files it's not gonna work very nicely for big files.

If missing <?php was the issue, new added\created files should be highlighted in this case, but they are not.

[progserg]

same problem

[ABOryn]

+1
Linux Mint 21.1, FireFox 109.0.1 (64-bit)

[gempir]

I debugged it.

It doesn't know the correct lexer to use for the file. So it let's chroma guess. But Chroma prefers phtml over php. Which results in no real syntax highlighting.

alecthomas/chroma#577

[gempir]

Workaround for now:

Create a .gitattributes file in your repo with:

*.php linguist-language=php

Then the syntax highlighting works!

[silverwind]

Lets continue in #33358 regarding the problem with line-by-line syntax highlighting.

[wxiaoguang]

It is another different case than #33358, because chroma requires php file to start with <?php.

Although 33358 could help, but I think for this case, upstream or we could have a quick solution.