Skip to content

[API] Add modified/created time to contents #32886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mmarif4u opened this issue Dec 18, 2024 · 4 comments · Fixed by #32921
Closed

[API] Add modified/created time to contents #32886

mmarif4u opened this issue Dec 18, 2024 · 4 comments · Fixed by #32921
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. topic/api Concerns mainly the API type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.24.0

Comments

@mmarif4u
Copy link

Feature Description

It would be nice if the API for files (contents) return the modified/created time too.

API ref: https://codeberg.org/api/swagger#/repository/repoGetContentsList
Ref link: https://codeberg.org/gitnex/GitNex/issues/1225

cc @6543 if you are still active here. :)

Screenshots

No response
@mmarif4u mmarif4u added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Dec 18, 2024
@lunny
Copy link
Member

lunny commented Dec 19, 2024

Hi, I think the last modified/created time can be read from the last commit.

+ LastCommitWhen : lastCommit.Author.When,

@lunny lunny added topic/api Concerns mainly the API proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. labels Dec 19, 2024
@mmarif4u
Copy link
Author

Hi @lunny, I guess you are referring to the code implementation that needs to be done.

A date object can be added from the lastCommit.Author.When to the json output.

@lunny lunny mentioned this issue Dec 20, 2024
Merged
@lunny lunny added this to the 1.24.0 milestone Mar 3, 2025
@lunny
Copy link
Member

lunny commented Mar 4, 2025 •
edited
Loading

I used LastCommitWhen in #32921. Maybe Author time is better?

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 3, 2025 •
edited
Loading

I used LastCommitWhen in #32921. Maybe Author time is better?

Let's add both: LastCommiterDate and LastAuthorDate, let the caller decide

lunny added a commit that referenced this issue Apr 3, 2025
@lunny @wxiaoguang
Add last_committer_date and last_author_date for file contents API (
45c4593 
#32921)

Fix #32886

Add `last_committer_date` and `last_author_date` in the content API
which is not implemented by Github API v3 at the moment.

Co-authored-by: wxiaoguang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. topic/api Concerns mainly the API type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging a pull request may close this issue.

Add last_committer_date and last_author_date for file contents API lunny/gitea
3 participants
@lunny @mmarif4u @wxiaoguang