Skip to content

Action view branch button doesn't check for deleted branch #32761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stuzer05 opened this issue Dec 8, 2024 · 2 comments · Fixed by #32764 or #32848
Closed

Action view branch button doesn't check for deleted branch #32761

stuzer05 opened this issue Dec 8, 2024 · 2 comments · Fixed by #32764 or #32848
Labels
type/bug
Milestone
1.23.0

Comments

@stuzer05
Copy link
Contributor

stuzer05 commented Dec 8, 2024

Description

image
Clicking on this button when branch was deleted show. In other pages branch existance is checked

Gitea Version

trunk

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

None
@lunny lunny mentioned this issue Dec 8, 2024
Merged
@lunny lunny added this to the 1.23.0 milestone Dec 8, 2024
@lunny lunny closed this as completed in 6370d2f Dec 12, 2024
@stuzer05
Copy link
Contributor Author

@lunny deleted branch check isn't working properly
image

here, task/test#1 branch was deleted once. then recreated and new action is ongoing on task/test#1 (as shown on screenshot). But for some reason branch task/test#1 is crossed out. Also, master branch is crossed out but it exists

@stuzer05
Copy link
Contributor Author

stuzer05 commented Dec 13, 2024 •
edited
Loading

Check works properly under PR title and action view (not list)

@wxiaoguang wxiaoguang reopened this Dec 13, 2024
@lunny lunny mentioned this issue Dec 15, 2024
Merged
@lunny lunny closed this as completed in 4209084 Dec 15, 2024
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Dec 24, 2024
@lunny @earl-warren
Fix bug on action list deleted branch (#32848)
967e045 
Fix
go-gitea/gitea#32761 (comment)

---------

Co-authored-by: wxiaoguang <[email protected]>
(cherry picked from commit 42090844ed2de5e615abc6ece351c152d3344295)

Conflicts:
	models/fixtures/action_run.yml
	models/fixtures/branch.yml
	routers/web/repo/actions/actions_test.go
  trivial context conflict
richmahn pushed a commit to unfoldingWord/dcs that referenced this issue Mar 2, 2025
@lunny @wxiaoguang @richmahn
Fix bug on action list deleted branch (#32848)
e5f1f7d 
Fix
go-gitea/gitea#32761 (comment)

---------

Co-authored-by: wxiaoguang <[email protected]>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.23.0
3 participants
@lunny @wxiaoguang @stuzer05