Discord Webhooks should hide multiline commit details

[quentinguidee]

Description

While #31668 was resolved (thanks!), the messages of Discord webhooks is still hard/harder to read in some cases like this one :

Now, the message is truncated after 50 characters like GitHub, but I think that only the first line of the message should be displayed. See GitHub for comparison (these are also multiline commits) :

Gitea Version

1.22.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

2.30.2

Operating System

Linux

How are you running Gitea?

Official docker image

Database

PostgreSQL

[kemzeb]

Thanks for the report! This is unattended behavior... #31970 should have removed the commit description and just kept the summary:

gitea/services/webhook/discord.go

Line 159 in 41b4ef8

message := strings.TrimRight(strings.SplitN(commit.Message, "\n", 1)[0], "\r")

Here we split the commit message with \n as the delimiter and we only choose the first line. It also removes any trailing /r if it exists.

Looking at the Go docs further, I may have misused SplitN() and should have done:

strings.SplitN(commit.Message, "\n", 2)[0]

... since the last element would be the "unsplit remainder" that the docs talk about. Currently we seem to be using the unsplit remainder (which would just be the message). Reading the code of strings.SplitN() also points to this being the case. That PR also had a unit test, but didn't catch this edge case since the commit summary was > 50 (while yours is < 50).

Not sure how I missed this. I'll be making a PR to correct this.