Actionable References Not Triggering on Manually Merges

[cyrilkong]

Description

Hi Gitea team,

I’ve encountered a bug with the actionable references feature. When a pull request is manually merged, the automatic closing behavior of referenced issues is not triggered as expected.

For example, I had a pull request with the description “This PR closes #909090”. After manually merging the pull request, issue #909090 was not automatically closed, and no notification was created on the issue as the documentation suggests should happen.

This behavior is inconsistent with the feature’s description, which states that issues should be closed if the merger of the pull request has the necessary permissions. I do have the permissions to close the issue, but the actionable reference did not take effect upon merging.

This bug affects the workflow for issue tracking and resolution, as it requires manual intervention to update the issue status after merging a PR. It could lead to inconsistencies in the issue tracking system and additional workload for the team.

Could you please look into this issue and advise on how it can be resolved? It’s an important feature for maintaining our issue tracking efficiency.

Thank you for your attention to this matter. Keep up the great work.

Gitea Version

1.23.0+dev-345-gecc8f2b047

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Attached on https://forum.gitea.com/t/actionable-references-not-triggering-on-manually-merges/9525

Git Version

No response

Operating System

No response

How are you running Gitea?

All actions could reproduce via demo.gitea.com

Database

None

[Zettat123]

Thanks for the bug report. But I cannot reproduce this issue on the demo site. Could you provide some steps to help us reproduce this issue?

[cyrilkong]

Thanks for the bug report. But I cannot reproduce this issue on the demo site. Could you provide some steps to help us reproduce this issue?

Sure, here it is

1. assume you have a repo, with a different branch, so you've got "master" and "branch1"
2. create a issue named it "bug1", pretend to act as bug report
3. so you will have a ISSUE_ID on "bug1"
4. now try to edit your code whatever did just commit and update to "branch1", pretend to act as bugfix for "bug1"
5. go for pull request, and create a pull request from "branch1" into "master", write down comment in conversation
6. in the comment, say Closes #ISSUE_ID, it's a command which call actionable references, meanwhile this PR will auto-close the "bug1" if merged by reviewer
7. reviewer(in this case, so you are) take a "manually merge" for this PR after review and approve
8. normally, the action "merge" should reaction the call "auto-close" references, #ISSUE_ID of "bug1" should be closed
9. but it's not

[cyrilkong]

actionable reference like this.

and manually merged will give you a tag on PR.

[cyrilkong]

yes I am following~