-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Images missing in editor markdown preview #31294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
brechtvl
added a commit
to brechtvl/gitea
that referenced
this issue
Jun 9, 2024
Parse base path and tree path so that media links can be correctly created with /media/. Resolves go-gitea#31294
wxiaoguang
pushed a commit
to brechtvl/gitea
that referenced
this issue
Jun 16, 2024
Parse base path and tree path so that media links can be correctly created with /media/. Resolves go-gitea#31294
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this issue
Jun 17, 2024
Parse base path and tree path so that media links can be correctly created with /media/. Resolves go-gitea#31294 --------- Co-authored-by: wxiaoguang <[email protected]> # Conflicts: # routers/common/markup.go
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this issue
Jun 17, 2024
Parse base path and tree path so that media links can be correctly created with /media/. Resolves go-gitea#31294 --------- Co-authored-by: wxiaoguang <[email protected]> # Conflicts: # routers/common/markup.go
wxiaoguang
added a commit
that referenced
this issue
Jun 17, 2024
) Backport #31299 Parse base path and tree path so that media links can be correctly created with /media/. Resolves #31294 --------- Co-authored-by: Brecht Van Lommel <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
When using the editor to edit a markdown file with images, the Preview tab no longer shows images. The images do show correctly when viewing the markdown file without the editor.
Example:
https://demo.gitea.com/brechtvl/test
It appears to be caused by #26745. The link is wrong and
/src/
should be replaced by/media/
, which used to happen before this change.RenderMarkup
inrouters/common/markup.go
should probably create amarkup.Links
withBranchPath
andTreePath
, but I'm not sure what the best way is to achieve that.Gitea Version
1.22 (bbe98a3)
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
Ubuntu Linux 23.10
How are you running Gitea?
Running own build from command line.
Database
SQLite
The text was updated successfully, but these errors were encountered: