Skip to content

The corners of the folded review files in pull request conversation page are not right. #29933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lunny opened this issue Mar 20, 2024 · 2 comments · Fixed by #29953
Closed

The corners of the folded review files in pull request conversation page are not right. #29933

lunny opened this issue Mar 20, 2024 · 2 comments · Fixed by #29953
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@lunny
Copy link
Member

lunny commented Mar 20, 2024

image
@lunny lunny added type/bug topic/ui Change the appearance of the Gitea UI labels Mar 20, 2024
@silverwind
Copy link
Member

silverwind commented Mar 20, 2024 •
edited
Loading

I remember fixing this a long time ago with some CSS, must have regressed.

@HEREYUA
Copy link
Contributor

HEREYUA commented Mar 21, 2024

It might be due to this CSS
image

@HEREYUA HEREYUA mentioned this issue Mar 21, 2024
Merged
silverwind added a commit that referenced this issue Mar 29, 2024
@HEREYUA @silverwind
Fix:the rounded corners of the folded file are not displayed correctly (
c9068ef 
#29953)

Fix:    [#29933](#29933)

**Before**


![image](https://github.com/go-gitea/gitea/assets/37935145/71ec80f6-5896-4e4a-b686-4d792c11ebe2)


**After**


![image](https://github.com/go-gitea/gitea/assets/37935145/81348a61-946a-4562-881d-8d873e50228f)

---------

Co-authored-by: silverwind <[email protected]>
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Mar 29, 2024
@HEREYUA @silverwind @GiteaBot
Fix:the rounded corners of the folded file are not displayed correctly (
5e00fa7 
go-gitea#29953)

Fix:    [go-gitea#29933](go-gitea#29933)

**Before**


![image](https://github.com/go-gitea/gitea/assets/37935145/71ec80f6-5896-4e4a-b686-4d792c11ebe2)


**After**


![image](https://github.com/go-gitea/gitea/assets/37935145/81348a61-946a-4562-881d-8d873e50228f)

---------

Co-authored-by: silverwind <[email protected]>
@GiteaBot GiteaBot mentioned this issue Mar 29, 2024
Merged
lunny pushed a commit that referenced this issue Mar 29, 2024
@GiteaBot @HEREYUA @silverwind
Fix:the rounded corners of the folded file are not displayed correctly (
05766d0 
#29953) (#30177)

Backport #29953 by @HEREYUA

Fix:    [#29933](#29933)

**Before**

![image](https://github.com/go-gitea/gitea/assets/37935145/71ec80f6-5896-4e4a-b686-4d792c11ebe2)

**After**

![image](https://github.com/go-gitea/gitea/assets/37935145/81348a61-946a-4562-881d-8d873e50228f)

Co-authored-by: HEREYUA <[email protected]>
Co-authored-by: silverwind <[email protected]>
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Apr 8, 2024
@HEREYUA @silverwind @algernon
Fix:the rounded corners of the folded file are not displayed correctl…
43122ca 
…y (#29953)

Fix:    [#29933](go-gitea/gitea#29933)

**Before**

![image](https://github.com/go-gitea/gitea/assets/37935145/71ec80f6-5896-4e4a-b686-4d792c11ebe2)

**After**

![image](https://github.com/go-gitea/gitea/assets/37935145/81348a61-946a-4562-881d-8d873e50228f)

---------

Co-authored-by: silverwind <[email protected]>
Conflicts:
	- web_src/css/modules/segment.css
	  Ported by adding the new selector with a larger radius,
          keeping the existing one with ours.
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Apr 8, 2024
@HEREYUA @silverwind
Fix:the rounded corners of the folded file are not displayed correctl…
b912e26 
…y (#29953)

Fix:    [#29933](go-gitea/gitea#29933)

**Before**

![image](https://github.com/go-gitea/gitea/assets/37935145/71ec80f6-5896-4e4a-b686-4d792c11ebe2)

**After**

![image](https://github.com/go-gitea/gitea/assets/37935145/81348a61-946a-4562-881d-8d873e50228f)

---------

Co-authored-by: silverwind <[email protected]>
Conflicts:
	- web_src/css/modules/segment.css
	  Ported by adding the new selector with a larger radius,
          keeping the existing one with ours.
(cherry picked from commit 43122ca)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix:the rounded corners of the folded file are not displayed correctly HEREYUA/gitea
3 participants
@lunny @silverwind @HEREYUA