Skip to content

Wrong default branch while switching between branches via the web interface #27008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lng2020 opened this issue Sep 11, 2023 · 4 comments · Fixed by #27053
Closed

Wrong default branch while switching between branches via the web interface #27008

lng2020 opened this issue Sep 11, 2023 · 4 comments · Fixed by #27053
Labels
type/bug

Comments

@lng2020
Copy link
Member

lng2020 commented Sep 11, 2023

Description

When switching between branches via the web interface, the default branch should remain unchanged.
ksnip_20230911-153517
e.g. The default branch should remain main

Gitea Version

latest codebase

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

building Gitea from source code

Database

None
@CaiCandong
Copy link
Member

@yp05327

@lng2020
Copy link
Member Author

lng2020 commented Sep 11, 2023

caused by pr #26697

@yp05327
Copy link
Contributor

yp05327 commented Sep 11, 2023 •
edited
Loading

image
$defaultBranch is not the repo's default branch, the naming of this variable in the existing code is confusing.

@wxiaoguang
Copy link
Contributor

Yup, it is, and I also left some comments ....

image

@yp05327 yp05327 mentioned this issue Sep 13, 2023
Merged
techknowlogick pushed a commit that referenced this issue Sep 14, 2023
@yp05327
Fix incorrect default branch label while switching between branches (#…
076eca8 
…27053)

Fix #27008
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect default branch label while switching between branches yp05327/gitea
4 participants
@wxiaoguang @yp05327 @CaiCandong @lng2020