Skip to content

"Comment and close" replaces first issue comment with last comment #2551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 7 tasks
mxmehl opened this issue Sep 19, 2017 · 4 comments · Fixed by #2833
Closed
2 of 7 tasks

"Comment and close" replaces first issue comment with last comment #2551

mxmehl opened this issue Sep 19, 2017 · 4 comments · Fixed by #2833
Labels
Milestone

Comments

@mxmehl
Copy link

mxmehl commented Sep 19, 2017

Description

This is a very severe bug because is modifies issues and potentially important information!

In an open issue, when clicking "comment and close", the text of the closing comment replaces the text of the first comment in this issue (fortunately not those in between).

Examples: https://try.gitea.io/mxmehl/test1/issues/1 or https://git.fsfe.org/pmpc/website/issues/89

@mxmehl
Copy link
Author

mxmehl commented Sep 19, 2017

This has already been the case with commit b0f7457, the version we had running before, but not with 5f4210a

@mxmehl mxmehl changed the title "Comment and close" rewrites first issue post with last message "Comment and close" replaces first issue comment with last comment Sep 19, 2017
@lunny lunny added the type/bug label Sep 19, 2017
@lafriks lafriks added this to the 1.x.x milestone Sep 19, 2017
@bkcsoft bkcsoft added issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP and removed type/bug labels Sep 19, 2017
@bkcsoft bkcsoft modified the milestones: 1.x.x, 1.2.0 Sep 19, 2017
@lafriks lafriks modified the milestones: 1.2.0, 1.x.x Sep 20, 2017
@lafriks lafriks removed the issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP label Sep 20, 2017
@lafriks
Copy link
Member

lafriks commented Sep 20, 2017

Not present in 1.2.0-rc2 only on master branch

@mxmehl
Copy link
Author

mxmehl commented Sep 20, 2017

The bug also happens when reopening an issue with a comment.

Does anyone have an idea how this could have been caused in the latest commits?

@mxmehl
Copy link
Author

mxmehl commented Sep 21, 2017

Workaround: Comment on an issue, and close it in a second step. Then the first message isn't overwritten. But who does it this way if there's a shortcut?

@lafriks lafriks modified the milestones: 1.x.x, 1.3.0 Nov 2, 2017
@lafriks lafriks added type/bug and removed issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change labels Nov 2, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants