Skip to content

User dropdown hidden on context row #24460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
silverwind opened this issue May 1, 2023 · 3 comments · Fixed by #24462
Closed

User dropdown hidden on context row #24460

silverwind opened this issue May 1, 2023 · 3 comments · Fixed by #24462
Assignees
@wxiaoguang
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.20.0

Comments

@silverwind
Copy link
Member

silverwind commented May 1, 2023 •
edited
Loading

Description

There is a regression from #24393 with g-menu-stackable-scrollable which prevents the dropdown from showing on https://try.gitea.io/issues when clicking user button top-left:

image

I recommend removing such overflow hiding. It can not work with non-portalled dropdowns like fomantic's.
@silverwind silverwind mentioned this issue May 1, 2023
Merged
@silverwind silverwind added the topic/ui Change the appearance of the Gitea UI label May 1, 2023
@silverwind silverwind added this to the 1.20.0 milestone May 1, 2023
@wxiaoguang wxiaoguang self-assigned this May 1, 2023
@wxiaoguang
Copy link
Contributor

Well, it seems that it just unnecessary .... no idea why I wrote so ... will remove it

@silverwind
Copy link
Member Author

silverwind commented May 1, 2023 •
edited
Loading

I think I would just remove this g-menu-stackable-scrollable altogether.

@wxiaoguang wxiaoguang mentioned this issue May 1, 2023
Merged
@wxiaoguang
Copy link
Contributor

Remove unnecessary g-menu-stackable-scrollable #24462

silverwind pushed a commit that referenced this issue May 1, 2023
@wxiaoguang
Remove unnecessary g-menu-stackable-scrollable (#24462)
ce16ff6 
Fix #24460

That's a mistake but ..... no idea why I wrote so ... remove it.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wxiaoguang wxiaoguang

Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging a pull request may close this issue.

Remove unnecessary g-menu-stackable-scrollable wxiaoguang/gitea
2 participants
@silverwind @wxiaoguang