Generated installation URL for PyPI repository packages has an escaping problem

[Gunzinger]

Description

Hi dear gitea maintainers!

First off: Thank you for the great software, I am enjoying it a lot and it saves a lot of resources on my VPS compared to GitLab which I was using previously!

Now to the bug:
There seems to be a problem in the URL escaping of the gitea-origin-url templates, in which the space is url-escaped to %20 when it should remain a space.

Reproduction of the bug in the demo site: https://try.gitea.io/test-pypi-url-bug/-/packages/pypi/pypi-url-test/0.1.0

Might have been introduced in this commit: e7ef94e

Screenshots

Gitea Version

1.19.0 (official docker container)

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Windows 10

Browser Version

Firefox 111.0.1

[Gunzinger]

Working on a PR, I think this is an easy fix by adjusting the pypi.tmpl and allows for the addition of a trailing slash to the repository URL in accordance to PEP-503.

EDIT:
As can be seen below, the PR is now ready.
I took a quick look through the other templates in the blamed commit, and none of them seem to have a space inside the data-url attribute of the gitea-origin-url element, which leads me to believe the PyPI link is the only one to be affected.

[silverwind]

Is this suffix supposed to be part of the URL? If yes, the escaping would be correct.

Edit: I guess I am wrong 😉

[Gunzinger]

For anybody stumbling upon this, the suffix in this case is the package name, and as such not part of the URL, thanks for the approve (being curious is far away from being wrong) :)