Show More button no longer works #22380
Comments
vladimirhasko
added a commit
to opentelekomcloud-infra/system-config
that referenced
this issue
Jan 10, 2023
|
Some kind of workaround: Right click the show more button in chrome and inspect the element -> there's a relative address there ("data-href") and replace the end of the url in the address bar with it. This method is not perfect, because it shows more, but the already shown stuffs go away. |
otc-zuul bot
pushed a commit
to opentelekomcloud-infra/system-config
that referenced
this issue
Jan 10, 2023
…ea#22380 (#706) Rollback of gitea version due to bug on show more files go-gitea/gitea#22380 Reviewed-by: Artem Goncharov
|
This is a very ugly workaround for people not so skilled and I made a mistake to deploy this prod already (what now affects many people). |
|
Are there any logs? |
|
I believe this is likely to be a regression from #21012 |
|
No logs make sense here, since UI doesn't trigger any action |
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
Jan 10, 2023
There was a serious regression in go-gitea#21012 which broke the Show More button on the diff page, and the show more button was also broken on the file tree too. This PR fixes this by resetting the pageData.diffFiles as the vue watched value and reattachs a function to the show more button outside of the file tree view. Fix go-gitea#22380 Signed-off-by: Andrew Thornton <[email protected]>
lunny
added a commit
that referenced
this issue
Jan 13, 2023
There was a serious regression in #21012 which broke the Show More button on the diff page, and the show more button was also broken on the file tree too. This PR fixes this by resetting the pageData.diffFiles as the vue watched value and reattachs a function to the show more button outside of the file tree view. Fix #22380 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: John Olheiser <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
|
is the fix going to be backported/released with 1.18.1? |
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
Jan 13, 2023
Backport go-gitea#22399 There was a serious regression in go-gitea#21012 which broke the Show More button on the diff page, and the show more button was also broken on the file tree too. This PR fixes this by resetting the pageData.diffFiles as the vue watched value and reattachs a function to the show more button outside of the file tree view. Fix go-gitea#22380 Signed-off-by: Andrew Thornton <[email protected]>
lunny
pushed a commit
that referenced
this issue
Jan 13, 2023
Backport #22399 There was a serious regression in #21012 which broke the Show More button on the diff page, and the show more button was also broken on the file tree too. This PR fixes this by resetting the pageData.diffFiles as the vue watched value and reattachs a function to the show more button outside of the file tree view. Fix #22380 Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
In the PRs with more changed files then the project limit a "Show More" button is no longer doing anything since the 1.18.0. In the 1.17.0 it was working.
There seem to be no JS errors on the page either, but clicking just on the button is just having no effect
Screenshots
Gitea Version
1.18.0
Can you reproduce the bug on the Gitea demo site?
Yes
Operating System
No response
Browser Version
Firefox 1.108 and Chrome 104.0
The text was updated successfully, but these errors were encountered: