Building Gitea will build go-sqlite3 with or without the sqlite build tag

[dubeg]

• Gitea version (or commit ref): master
• Git version: 2.8.1
• Operating system: Windows 10
• Database:
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
  • Not relevant
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:
  • Not relevant

Description

Even without specifying "sqlite" as a build tag, the command go build main.go will also build the vendor go-sqlite3, which requires gcc.

Screenshots

Note

Currently, two of Gitea's files import this vendor: models/models_sqlite.go and models/unit_tests.go. The former has the sqlite build constraint, while the latter does not. This is probably the root of this issue.

[go2sh]

The sqlite tag only touches the final product not the tests. One could argue to add a different command for building the tests. But this an enhancement not a bug.

[lafriks]

@go2sh if it is not possible to build gitea without gcc than it is a bug