Skip to content

draft releases: update & delete events being sent while creation dont #21448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Mai-Lapyst opened this issue Oct 13, 2022 · 4 comments · Fixed by #21451
Closed

draft releases: update & delete events being sent while creation dont #21448

Mai-Lapyst opened this issue Oct 13, 2022 · 4 comments · Fixed by #21451
Labels
type/bug

Comments

@Mai-Lapyst
Copy link
Contributor

Description

Pretty much what the title says: while creation events are not being sent when creating an release marked as draft, update and deletion events are, which seems counter intuitive; it should either be all sent or non of them for draft releases.

Gitea Version

1.17.2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

linux

How are you running Gitea?

Official binary release

Database

MySQL
@KN4CK3R KN4CK3R mentioned this issue Oct 14, 2022
Merged
techknowlogick pushed a commit that referenced this issue Oct 17, 2022
@KN4CK3R @wxiaoguang
@lunny @6543
Do not send notifications for draft releases (#21451)
a37e8b2 
Fixes #21448

Co-authored-by: wxiaoguang <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: 6543 <[email protected]>
@delvh
Copy link
Member

delvh commented Oct 25, 2022

Fix has been reverted for further discussion.

@delvh delvh reopened this Oct 25, 2022
@lunny
Copy link
Member

lunny commented Jul 27, 2023 •
edited
Loading

I lost the information about why the PR has been reverted. OK. Got from #21451

We can have clarify about the logic, my proposal is

1 Creating a non-draft release -> trigger CreateRelease event
2 Creating a draft release -> no event
3 Convert a draft to a non-draft -> trigger CreateRelease event
4 Convert a non-draft to a draft -> trigger DeleteRelease event
5 Edit a non-draft release -> trigger EditRelease event
6 Edit a draft release -> no event
7 DELETE a non-draft release -> trigger DeleteRelease event
8 DELETE a draft release -> no event

@wxiaoguang
Copy link
Contributor

Everything in #21451

@lunny
Copy link
Member

lunny commented Mar 25, 2024

I think this has been resolveded by #29008

@lunny lunny closed this as completed Mar 25, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not send notifications for draft releases KN4CK3R/gitea
4 participants
@lunny @wxiaoguang @delvh @Mai-Lapyst