Branch protection user/team dropdowns do not list everyone

[Fogapod]

Description

I tried setting up whitelists for branch protection but dropdowns only list 4 out of 9 org members. Text search only searches among these 4.

Similar thing happened to teams - one of the teams wasnt showing. It worked after team recreation.

I noticed that each of these 4 members is on top of user list of some team. Membership from top to bottom for 1st screenshot:

• none, is website admin
• CI
• devs-back (bottom); lead-devs (top)
• devs-back (top)

Gitea Version

1.17.0+rc1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Locally compiled binary

Database

PostgreSQL

[lunny]

Could you confirm all of the 9 members have read permissions to that repository?

[Fogapod]

Could you confirm all of the 9 members have read permissions to that repository?

Yes.

So here is a devs-back team:

It has access to all currently exising repositories (as seen in ui). Look at 3 top members. Red avatar is listed in dropdown while 2 other people are not. All these 3 people only have a single role. 4th member is also a member of other team.

Team permissions:

[Fogapod]

This might be related: trying to add team to repository collaborators, search does not work at all, request logs say it always 404s. Even if i type in team name exactly search shows 404 even though pressing button successfully adds that team

[Gusted]

I've looked into the issue and the code for this is correct and straightforward. But it's likely that you didn't add the teams to the repository(otherwise other issues would arise if this is already the case). Also for the 404's it's not reproducible for me.

[Fogapod]

it has access to that repository. it is the only team that grants write access. we wouldn't be able to push code if it wasn't the case. people have write and read access because they are in team but they are not listed:

today i've got 4 different users shown in that list. still not everyone:

[Gusted]

Is the list scrollable?

[Fogapod]

not only it is scrollable today, it lists everyone who has repo access properly, not just 4 people.
the only change i made was granting that team all permissions.

unchecking any of these results in 3 people shown, not scrollable. i can reliably reproduce this by switching any permission.

i have a similar issue with package registry: #19986
it looks like granting all Write permissions does something special. having any of them as Read breaks things

[Gusted]

So it seems like the code was correct, however the code to store the access information into the database wasn't. Fixed by #20275