Skip to content

README rendering broken #19988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wxiaoguang opened this issue Jun 16, 2022 · 2 comments · Fixed by #19992
Closed

README rendering broken #19988

wxiaoguang opened this issue Jun 16, 2022 · 2 comments · Fixed by #19992
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change type/bug
Milestone
1.17.0

Comments

@wxiaoguang
Copy link
Contributor

https://try.gitea.io/wxiaoguang/test

image
@wxiaoguang wxiaoguang added this to the 1.17.0 milestone Jun 16, 2022
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Jun 16, 2022 •
edited
Loading

Three related changes (RelativePath) in #19017

Maybe the first one (renderReadmeFile) should be changed back (and adding the tree path prefix?), the ctx.Repo.TreePath is empty here.

image

@wxiaoguang wxiaoguang added the issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change label Jun 16, 2022
@lunny
Copy link
Member

lunny commented Jun 17, 2022 

web/repo/view.go:366:renderReadmeFile() [E] [62abdc6e] Render failed: Render options both filename and type missing then fallback

@lunny lunny mentioned this issue Jun 17, 2022
Merged
zeripath added a commit that referenced this issue Jun 17, 2022
@lunny @zeripath
Fix Readme render bug (#19992)
bdde56c 
Fix #19988 

Co-authored-by: zeripath <[email protected]>
vsysoev pushed a commit to IntegraSDL/gitea that referenced this issue Aug 10, 2022
@lunny @zeripath
Fix Readme render bug (go-gitea#19992)
013632d 
Fix go-gitea#19988 

Co-authored-by: zeripath <[email protected]>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this issue Aug 24, 2022
@lunny @zeripath @AbdulrhmnGhanem
Fix Readme render bug (go-gitea#19992)
50c5cab 
Fix go-gitea#19988 

Co-authored-by: zeripath <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging a pull request may close this issue.

Fix Readme render bug lunny/gitea
2 participants
@lunny @wxiaoguang