-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Conflict detection for PR is broken with git >= 2.32.0 #18514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I found at least one problem: https://github.com/go-gitea/gitea/blame/main/services/pull/patch.go#L347 This code applies
and
And following code is unable to parse output with |
Unforunately git apply --3way reports conflicts differently than standard patches resulting in conflicts being missed. Adjust the conflict detection code to account for this different error reporting. Fix go-gitea#18514 Signed-off-by: Andrew Thornton <[email protected]>
Backport go-gitea#18536 Unforunately git apply --3way reports conflicts differently than standard patches resulting in conflicts being missed. Adjust the conflict detection code to account for this different error reporting. Fix go-gitea#18514 Signed-off-by: Andrew Thornton <[email protected]>
* Detect conflicts with 3way merge Unforunately git apply --3way reports conflicts differently than standard patches resulting in conflicts being missed. Adjust the conflict detection code to account for this different error reporting. Fix #18514 Signed-off-by: Andrew Thornton <[email protected]> * and three-way failed Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
Backport #18536 Unforunately git apply --3way reports conflicts differently than standard patches resulting in conflicts being missed. Adjust the conflict detection code to account for this different error reporting. Fix #18514 Signed-off-by: Andrew Thornton <[email protected]>
* Detect conflicts with 3way merge Unforunately git apply --3way reports conflicts differently than standard patches resulting in conflicts being missed. Adjust the conflict detection code to account for this different error reporting. Fix go-gitea#18514 Signed-off-by: Andrew Thornton <[email protected]> * and three-way failed Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
Gitea Version
1.16.0, 1.17.0+dev-74-g80048c091
Git Version
2.35.1, gitea demo git version
Operating System
No response
How are you running Gitea?
Built by myself and https://try.gitea.io
Database
No response
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Description
1
11
12
13
Both feature1 and feature2 PRs will show:
Pressing 'Update branch by merge' or 'Update branch by rebase' will show no any visual changes (just page refresh) on demo site and will show 'Merge conflict checking is in progress. Try again in few moments' on my own install (refreshing page will show no changes).
Pressing 'Create merge commit' will show red panel reporting merge conflict with bad translation: 'editor.merge_conflict'.
Pressing 'Rebase then fast-forward' or 'Rebase then create merge commit' will show red panel reporting error message.
Pressing 'Create squash commit' will show server internal error 500.
Screenshots
The text was updated successfully, but these errors were encountered: