Skip to content

Custom label set not picked up in all places #16364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 6 tasks
pixelspark opened this issue Jul 7, 2021 · 2 comments · Fixed by #18564
Closed
2 of 6 tasks

Custom label set not picked up in all places #16364

pixelspark opened this issue Jul 7, 2021 · 2 comments · Fixed by #18564
Labels
topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Milestone

Comments

@pixelspark
Copy link

  • Gitea version (or commit ref): 1.14.4
  • Git version: 2.30.2 (seems irrelevant)
  • Operating system: Linux (Docker on Debian)
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
  • Log gist:

Description

After adding a custom label file to $GITEA_CUSTOM/options/label, the label set becomes available in the 'create repository' screen, but not as a preset on a repository's "labels" page.

Screenshots

In the below screenshot, the 'Dialogic' set is custom:

image

Nevertheless, it doesn't show up on the repository's label page:

image

I do not expect the label file itself to be the issue, nevertheless here it is:

#EC0000 bug ; Something is not working as it should
#CCCCCC duplicate ; This issue already exists
#27A581 feature ; A new feature is requested
#93BA5A user-request ; This was requested by an end-user
#1A7789 ui-ux ; This issue is related to a UI/UX issue
#DE8C3F chore ; This issue is related to non-user-facing changes (e.g. maintenance of code, tooling)
#003764 paid ; There is a direct budget to resolve this issue
#E8B63C performance ; This issue is related to performance
#f00eca easy ; This issue is probably easy to fix (a good first issue!)
@pixelspark
Copy link
Author

Note that saving my custom label set as $GITEA_CUSTOM/options/label/Default does replace the default set presented on the repository's label screen.

While this might be by design, it is a bit confusing. Suggestions for fixing:

  • Document this behaviour (tell users that the Default file is probably where they want to save labels, and that other labels will only be available for creation of new repositories)
  • Also present other label sets in the repository labels screen (and possibly also the organisation-wide screen, which also suggests the Default label set when there are no labels)

@pixelspark
Copy link
Author

Okay, I feel stupid. I simply didn't notice the 'default' rectangle is actually dropdown menu. This correctly shows my custom label set:

image

image

Maybe change the styling of the dropdown? (I am using Edge on a Mac, not sure how it looks elsewhere).

@noerw noerw added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Jul 10, 2021
zeripath pushed a commit that referenced this issue Feb 3, 2022
Fixes #15679 and the dupe of it: Fixes #16364.

Also removes a comment that links to a gogs forum thread.
@zeripath zeripath added this to the 1.16.1 milestone Feb 3, 2022
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
Fixes go-gitea#15679 and the dupe of it: Fixes go-gitea#16364.

Also removes a comment that links to a gogs forum thread.
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants