Skip to content

Not enough space in the Start Timer button for certain translations #15896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 6 tasks
emansije opened this issue May 16, 2021 · 1 comment · Fixed by #15524
Closed
2 of 6 tasks

Not enough space in the Start Timer button for certain translations #15896

emansije opened this issue May 16, 2021 · 1 comment · Fixed by #15524
Labels
topic/ui Change the appearance of the Gitea UI

Comments

@emansije
Copy link
Contributor

  • Gitea version (or commit ref): 1.14.2 (although other versions might be affected as well)
  • Git version: 2.27.0
  • Operating system: Kubuntu 20.10
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
  • Log gist:

Description

The "Start Timer" button of the Time Tracker in the editing issue page doesn't have enough space for the European Portuguese translation for the word "Timer" ("cronómetro"), but I've noticed that other languages have the same issue, like German, Spanish and Turkish.

The left and right padding of the button text is 1.5em. Perhaps making it 1.2em would solve the issue.

Screenshots

As it is now:

Screenshot_20210516_134806

After making the left and right padding 1.2em:

Screenshot_20210516_135015
@noerw noerw added the topic/ui Change the appearance of the Gitea UI label May 16, 2021
@silverwind
Copy link
Member

There is just not enough space for two side-by-side buttons, let's make it 2 rows:

image

silverwind added a commit to silverwind/gitea that referenced this issue May 16, 2021
@silverwind
Issue sidebar and misc css fixes
6caba83 
- Replace remaining font icons with SVG in issue sidebar
- Rework issue due date display
- Realign avatar in timeline
- Fix font size in repo search and code explore
- Consolidate active button styles
- Fix loading form on arc-green
- Align time tracker buttons vertically

Fixes: go-gitea#15896
@silverwind silverwind mentioned this issue May 16, 2021
Merged
@emansije emansije changed the title Not enough padding in the Start Timer button for certain translations Not enough space in the Start Timer button for certain translations May 16, 2021
6543 pushed a commit that referenced this issue May 16, 2021
@silverwind
Issue sidebar and misc css fixes (#15524)
a32bfd8 
- Replace remaining font icons with SVG in issue sidebar
- Rework issue due date display
- Realign avatar in timeline
- Fix font size in repo search and code explore
- Consolidate active button styles
- Fix loading form on arc-green
- Align time tracker buttons vertically

Fixes: #15896
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this issue Aug 10, 2021
@silverwind @AbdulrhmnGhanem
Issue sidebar and misc css fixes (go-gitea#15524)
ece413b 
- Replace remaining font icons with SVG in issue sidebar
- Rework issue due date display
- Realign avatar in timeline
- Fix font size in repo search and code explore
- Consolidate active button styles
- Fix loading form on arc-green
- Align time tracker buttons vertically

Fixes: go-gitea#15896
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue sidebar and misc css fixes silverwind/gitea
3 participants
@silverwind @emansije @noerw