Skip to content

Repo Transfer: If the sql transaction fails we will be left repository in the wrong place #14821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
6543 opened this issue Feb 27, 2021 · 2 comments · Fixed by #14864
Closed

Repo Transfer: If the sql transaction fails we will be left repository in the wrong place #14821

6543 opened this issue Feb 27, 2021 · 2 comments · Fixed by #14864
Labels
type/bug
Milestone
1.14.0

Comments

@6543
Copy link
Member

6543 commented Feb 27, 2021

If the transaction fails we will be left repository in the wrong place

Originally posted by @zeripath in #14792 (comment)
@6543 6543 mentioned this issue Feb 27, 2021
Merged
@6543 6543 self-assigned this Feb 27, 2021
@noerw
Copy link
Member

noerw commented Mar 2, 2021

@6543 is this fixed? Not sure how the linked PR is related

@noerw noerw added the type/bug label Mar 2, 2021
@6543
Copy link
Member Author

6543 commented Mar 2, 2021

Not jet ... related code was moved in that pull

@lunny lunny mentioned this issue Mar 3, 2021
Merged
@zeripath zeripath added this to the 1.14.1 milestone Mar 3, 2021
@6543 6543 removed their assignment Mar 4, 2021
@6543 6543 modified the milestones: 1.14.1, 1.14.0 Mar 4, 2021
6543 added a commit that referenced this issue Mar 5, 2021
@lunny @zeripath @6543
When transfering repository and database transaction failed, rollback…
7525450 
… the renames (#14864)

Fix #14821

Co-authored-by: Andrew Thornton <[email protected]>
Co-authored-by: 6543 <[email protected]>
6543 added a commit to 6543-forks/gitea that referenced this issue Mar 6, 2021
@lunny @zeripath @6543
When transfering repository and database transaction failed, rollback…
1de5698 
… the renames (go-gitea#14864)

Fix go-gitea#14821

Co-authored-by: Andrew Thornton <[email protected]>
Co-authored-by: 6543 <[email protected]>
@6543 6543 mentioned this issue Mar 6, 2021
Merged
lunny added a commit that referenced this issue Mar 6, 2021
@6543 @lunny @zeripath
When transfering repository and database transaction failed, rollback…
74dc223 
… the renames (#14864) (#14902)

Fix #14821

Co-authored-by: Andrew Thornton <[email protected]>
Co-authored-by: 6543 <[email protected]>

Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: Andrew Thornton <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging a pull request may close this issue.

When transfering repository and database transaction failed, rollback the renames lunny/gitea
3 participants
@zeripath @noerw @6543