404 error when opening a branch on the dashboard

[atomlong]

• Gitea version (or commit ref): 1.14.0+dev-381-g633dc80077
• Git version: 2.29.2
• Operating system: ArchLinuxARM (aarch64)
• Database (use [x]):
  • PostgreSQL
  • [x ] MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • [x ] Yes (provide example URL) https://try.gitea.io/atomlong/WiFiManager/src/branch/refs/heads/master
  • No
• Log gist:

Description

1. Push master branch to https://try.gitea.io/atomlong/WiFiManager
2. open the dashboard on page https://try.gitea.io
3. click "refs/heads/master" link
   
4. "Page Not Found" will come
   

My guess is that the branch name on the Dashboard panel is wrong, it should be 'master', not 'refs/heads/master'.

Screenshots

[zeripath]

the refs/heads/ should be being Trimmed

[zeripath]

This is happening because of #13882 - although any time anyone pushes the full reference they would see it. So it's more that it was revealed.

[zeripath]

I think the best solution is actually to simply TrimPrefix the refs/heads/ in action.GetBranch(). The argument being that we can do this safely as this will always have been correct and will be correct in future too.

[atomlong]

@zeripath Your PR doesn't solve the issue. Now the branch name becomes 'refs/heads/'.

This gitea version comes from your branch：https://github.com/zeripath/gitea/tree/fix-13979-action-branch-trim-BranchPrefix

[zeripath]

@zeripath Your PR doesn't solve the issue. Now the branch name becomes 'refs/heads/'.

that's because I'm an idiot who got the arguments to TrimPrefix the wrong way round.

Try again

[atomlong]

@lafriks @zeripath The issue has not been completely solved. If I push a tag to the repository, there will be redundant 'ref/tags'.
In addition, why there are two items on the Dashboard?

Please reopen this issue, or I will create another issue?

[zeripath]

So that's a different problem. Similar but different and it would have been better to open another issue.

[lunny]

Cannot reproduce this on 4aabbac

[atomlong]

@lunny I confirm that even the latest commit has not completely solved the issue.