Panic in git blame #12440

sbrl · 2020-08-06T01:12:17Z

Gitea version (or commit ref): 1.12.3
Git version: 2.17.1
Operating system: Ubuntu Server 18.04
Database (use [x]):
- PostgreSQL
- MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)
- No
- Not relevant
Log gist:

Description

When accessing a specific git blame, I get a HTTP error 500. I noticed this because the Googlebot was indexing my git server, and caught it. The specific URL is as follows: https://git.starbeamrainbowlabs.com/sbrl-github/Pepperminty-Wiki/blame/commit/edba3b9bf3af109935a8ec7dc76914611b0dcb2f/php_error.php

This particular repo is a backup mirror of https://github.com/sbrl/Pepperminty-Wiki, so the specific URL on GitHub is as follows: https://github.com/sbrl/Pepperminty-Wiki/blame/edba3b9bf3af109935a8ec7dc76914611b0dcb2f/php_error.php

Just thought I'd report, since it seems like a crash that might need fixing. Feel free to close this if it can't be debugged :-)

Screenshots

Stack trace from logs:

2020/08/06 02:04:32 ...les/context/panic.go:35:1() [E] PANIC:: runtime error: invalid memory address or nil pointer dereference
	/usr/local/go/src/runtime/panic.go:212 (0x452e59)
	/usr/local/go/src/runtime/signal_unix.go:695 (0x452ca8)
	/go/src/code.gitea.io/gitea/modules/git/blame.go:70 (0x9f9e74)
	/go/src/code.gitea.io/gitea/routers/repo/blame.go:160 (0x19a223b)
	/usr/local/go/src/reflect/value.go:460 (0x49cc3a)
	/usr/local/go/src/reflect/value.go:321 (0x49c143)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:177 (0xc2861b)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:137 (0xc27ff9)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:121 (0xc43548)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:112 (0x125dd74)
	/go/src/code.gitea.io/gitea/modules/context/repo.go:797 (0x125dd5d)
	/usr/local/go/src/reflect/value.go:460 (0x49cc3a)
	/usr/local/go/src/reflect/value.go:321 (0x49c143)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:177 (0xc2861b)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:137 (0xc27ff9)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:121 (0xc43548)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:112 (0x125c45f)
	/go/src/code.gitea.io/gitea/modules/context/repo.go:579 (0x125c448)
	/usr/local/go/src/reflect/value.go:460 (0x49cc3a)
	/usr/local/go/src/reflect/value.go:321 (0x49c143)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:177 (0xc2861b)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:137 (0xc27ff9)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:121 (0xc43548)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:112 (0x1259d54)
	/go/src/code.gitea.io/gitea/modules/context/panic.go:39 (0x1259d45)
	/usr/local/go/src/reflect/value.go:460 (0x49cc3a)
	/usr/local/go/src/reflect/value.go:321 (0x49c143)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:177 (0xc2861b)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:137 (0xc27ff9)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:121 (0xc43548)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:112 (0x1211935)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/session/session.go:192 (0x1211920)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:79 (0xc433f0)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:157 (0xc28347)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:135 (0xc280e8)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:121 (0xc43548)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:112 (0x1b497c7)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/gzip/gzip.go:139 (0x1b497ba)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:79 (0xc433f0)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:157 (0xc28347)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:135 (0xc280e8)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:121 (0xc43548)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:112 (0xc54975)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/recovery.go:161 (0xc54968)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/logger.go:40 (0xc46fb3)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:157 (0xc28347)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:135 (0xc280e8)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:121 (0xc43548)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:112 (0xc53ca0)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/logger.go:52 (0xc53c8b)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/logger.go:40 (0xc46fb3)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:157 (0xc28347)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/inject/inject.go:135 (0xc280e8)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/context.go:121 (0xc43548)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/router.go:187 (0xc55b86)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/router.go:303 (0xc4f585)
	/go/src/code.gitea.io/gitea/vendor/gitea.com/macaron/macaron/macaron.go:218 (0xc4830a)
	/go/src/code.gitea.io/gitea/vendor/github.com/gorilla/context/context.go:141 (0xeba293)
	/usr/local/go/src/net/http/server.go:2041 (0x750943)
	/usr/local/go/src/net/http/server.go:2836 (0x753cd2)
	/usr/local/go/src/net/http/server.go:1924 (0x74f73b)
	/usr/local/go/src/runtime/asm_amd64.s:1373 (0x46f030)

The text was updated successfully, but these errors were encountered:

stale · 2020-10-12T12:18:45Z

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

6543 · 2020-10-12T12:26:03Z

looks like at

gitea/modules/git/blame.go

Line 70 in 20c2bdf

blamePart.Lines = append(blamePart.Lines, code)

blamePart == nil <- witch should not be the case ...

6543 · 2020-10-12T12:29:04Z

bug in master (0e4f663) too

https://try.gitea.io/abcKing/Pepperminty-Wiki/blame/commit/edba3b9bf3af109935a8ec7dc76914611b0dcb2f/php_error.php

42wim · 2020-10-17T17:10:49Z

Did some debugging on this.
The issue is the scanner exits early on"bufio.Scanner: token too long".

https://golang.org/pkg/bufio/#Scanner

Scanning stops unrecoverably at EOF, the first I/O error, or a token too large to fit in the buffer. When a scan stops, the reader may have advanced arbitrarily far past the last token. Programs that need more control over error handling or large tokens, or must run sequential scans on a reader, should use bufio.Reader instead.

AlrikG · 2020-10-31T13:39:01Z

Is it fixed or not? It is the last ticket in milestone 1.13

lafriks · 2020-10-31T19:48:31Z

This is not fixed yet

Fix go-gitea#12440 Closes go-gitea#13192 Signed-off-by: Andrew Thornton <[email protected]>

…13470) Fix #12440 Closes #13192 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>

…o-gitea#13470) Fix go-gitea#12440 Closes go-gitea#13192 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>

…13492) Fix #12440 Closes #13192 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Andrew Thornton <[email protected]>

…13491) Fix #12440 Closes #13192 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Andrew Thornton <[email protected]>

sbrl · 2020-11-10T19:32:29Z

Thanks, everyone for fixing this :D

zeripath · 2020-11-10T21:16:43Z

the fix in #13470 is not a complete fix - it could do with a little more finesse as I wrote on the PR itself.

zeripath · 2020-11-10T21:17:41Z

(not least because the 4096 byte stripper could end up splitting within a rune.)

lunny added the type/bug label Aug 6, 2020

stale bot added the issue/stale label Oct 12, 2020

stale bot removed the issue/stale label Oct 12, 2020

lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Oct 12, 2020

6543 added this to the 1.12.6 milestone Oct 12, 2020

lafriks modified the milestones: 1.12.6, 1.13.0 Oct 15, 2020

42wim added a commit to 42wim/gitea that referenced this issue Oct 17, 2020

Increase reading blame lines to 1MB. Fixes go-gitea#12440

1361671

This comment has been minimized.

Sign in to view

zeripath added a commit to zeripath/gitea that referenced this issue Nov 8, 2020

Prevent panic on git blame by limiting lines to 4096 bytes at most

c3602de

Fix go-gitea#12440 Closes go-gitea#13192 Signed-off-by: Andrew Thornton <[email protected]>

zeripath mentioned this issue Nov 8, 2020

Prevent panic on git blame by limiting lines to 4096 bytes at most #13470

Merged

6543 pushed a commit to 6543-forks/gitea that referenced this issue Nov 9, 2020

Prevent panic on git blame by limiting lines to 4096 bytes at most

39aa06b

Fix go-gitea#12440 Closes go-gitea#13192 Signed-off-by: Andrew Thornton <[email protected]>

6543 pushed a commit to 6543-forks/gitea that referenced this issue Nov 9, 2020

Prevent panic on git blame by limiting lines to 4096 bytes at most

939762e

Fix go-gitea#12440 Closes go-gitea#13192 Signed-off-by: Andrew Thornton <[email protected]>

techknowlogick closed this as completed in #13470 Nov 10, 2020

techknowlogick added a commit that referenced this issue Nov 10, 2020

Prevent panic on git blame by limiting lines to 4096 bytes at most (#…

182b5a0

…13470) Fix #12440 Closes #13192 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>

This was referenced Nov 10, 2020

Prevent panic on git blame by limiting lines to 4096 bytes at most (#13470) #13494

Closed

Prevent panic on git blame by limiting lines to 4096 bytes at most (#13470) #13495

Closed

lafriks modified the milestones: 1.13.0, 1.12.6 Nov 10, 2020

zeripath added a commit that referenced this issue Nov 10, 2020

Prevent panic on git blame by limiting lines to 4096 bytes at most (#…

4a71d4d

…13492) Fix #12440 Closes #13192 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Andrew Thornton <[email protected]>

zeripath added a commit that referenced this issue Nov 10, 2020

Prevent panic on git blame by limiting lines to 4096 bytes at most (#…

8049de8

…13491) Fix #12440 Closes #13192 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Andrew Thornton <[email protected]>

go-gitea locked and limited conversation to collaborators Dec 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Panic in git blame #12440

Panic in git blame #12440

sbrl commented Aug 6, 2020

stale bot commented Oct 12, 2020

6543 commented Oct 12, 2020

6543 commented Oct 12, 2020 •

edited

Loading

42wim commented Oct 17, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

AlrikG commented Oct 31, 2020

lafriks commented Oct 31, 2020

sbrl commented Nov 10, 2020

zeripath commented Nov 10, 2020

zeripath commented Nov 10, 2020

Panic in git blame #12440

Panic in git blame #12440

Comments

sbrl commented Aug 6, 2020

Description

Screenshots

Stack trace from logs:

stale bot commented Oct 12, 2020

6543 commented Oct 12, 2020

6543 commented Oct 12, 2020 • edited Loading

42wim commented Oct 17, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

AlrikG commented Oct 31, 2020

lafriks commented Oct 31, 2020

sbrl commented Nov 10, 2020

zeripath commented Nov 10, 2020

zeripath commented Nov 10, 2020

6543 commented Oct 12, 2020 •

edited

Loading