Skip to content

Webhook deleting branch considered a push #10578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 7 tasks
iarepandemonium opened this issue Mar 2, 2020 · 5 comments
Closed
1 of 7 tasks

Webhook deleting branch considered a push #10578

iarepandemonium opened this issue Mar 2, 2020 · 5 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug

Comments

@iarepandemonium
Copy link

  • Gitea version (or commit ref): 1.11+ (We built a develop version of 1.12 that isnt released.)
  • Git version:
  • Operating system: Ubuntu
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

When I delete a branch its considered a push to the branch instead of deleting. Same with if a PR gets syncronized, its considered a push. If its accurate for them to be pushed, it would be helpful if deleting a branch ALSO had the 'action' field, that way I can filter it out so it doesn't built on my pipeline when i delete branches.
...

Screenshots

@svenborn
Copy link

svenborn commented Apr 2, 2020

Same for me. I've configured the webhook to only be triggered on Create and Push Events but the webhook is always triggered on Delete Events (git push -d origin branch).

image

@stale
Copy link

stale bot commented Jun 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Jun 2, 2020
@iarepandemonium
Copy link
Author

iarepandemonium commented Jun 2, 2020 via email

@stale stale bot removed the issue/stale label Jun 2, 2020
@stale
Copy link

stale bot commented Aug 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 1, 2020
@zeripath zeripath added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Aug 1, 2020
@stale stale bot removed the issue/stale label Aug 1, 2020
@zeripath
Copy link
Contributor

zeripath commented Sep 5, 2020

Fixed by #12212

@zeripath zeripath closed this as completed Sep 5, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Development

No branches or pull requests

4 participants