Open issue count not updated when closing through commits/PR merges

[bkraul]

• Gitea version (or commit ref): ge0ecddc11
• Git version: 1.12.0+dev-401
• Operating system: N/A
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes: https://try.gitea.io/bkraul/TestProject/issues/
  • No
  • Not relevant
• Log gist:

Description

Issue count indicators are not being properly updated when the issues are closed via commit messages or PR merges.

Steps to reproduce:

• Create a new issue.
• Add a commit to the project wit the Closes #... instruction.
• Push the commit.
• The issue will close as expected.
• The count of open issues will not be updated and you will still see the count as if the issue had not been closed.
• Restarting (recreating the docker container) updates the count.
  ...

Screenshots

Issue created:

Committing and pushing the change:

Issue closes, but count is not updated:

This issue appears related to #10360, and was supposed to have been fixed by #10364 but it seems it is not.

[solaristhesun]

Please fix this. It makes me mad :/

[zeripath]

OK it looks to me like the correct values are calculated but then they are incorrectly overwritten by another call to update repository...

[zeripath]

gitea/services/repository/push.go

Lines 362 to 365 in 89c94e2

	// Change repository empty status and update last updated time.
	if err := models.UpdateRepository(repo, false); err != nil {
	return fmt.Errorf("UpdateRepository: %v", err)
	}

Updates all the columns of the repository - overwriting the updated values.