use data- attributes to pass data

Author: HesterG

templates/base/page_dimmer_buttons.tmpl

@@ -1,9 +1,9 @@
 <div class="actions">
-	<button class="ui red cancel button">
+	<button class="ui red cancel button cancel-button">
 		{{svg "octicon-x"}}
 		{{if .ModalNoText}}{{.ModalNoText}}{{else}}{{.locale.Tr "modal.no"}}{{end}}
 	</button>
-	<button class="ui green ok button{{if .ExtendedClasses}} {{.ExtendedClasses}}{{end}}" {{if .DataUrl}}data-url="{{.DataUrl}}"{{end}}>
+	<button class="ui green ok button confirm-button">
 		{{svg "octicon-check"}}
 		{{if .ModalYesText}}{{.ModalYesText}}{{else}}{{.locale.Tr "modal.yes"}}{{end}}
 	</button>

templates/projects/view.tmpl

@@ -115,7 +115,10 @@
 										{{$.locale.Tr "repo.projects.column.unset_default"}}
 									</a>
 								{{end}}
-								<a class="item show-modal button" data-modal="#delete-board-modal-{{.ID}}">
+								<a class="item show-modal button show-delete-column-modal" 
+									data-modal="#delete-board-modal-{{.ID}}"
+									data-url="{{$.Link}}/{{.ID}}"
+								>
 									{{svg "octicon-trash"}}
 									{{$.locale.Tr "repo.projects.column.delete"}}
 								</a>
@@ -171,12 +174,9 @@
 											{{$.locale.Tr "repo.projects.column.deletion_desc"}}
 										</label>
 									</div>
-									<div class="text right actions">
-										{{$DataUrl := printf "%s/%d" $.Link .ID}}
-										{{$ModalNoText := $.locale.Tr "settings.cancel"}}
-										{{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}}
-										{{template "base/page_dimmer_buttons" (dict "." $ "ExtendedClasses" "delete-project-board" "DataUrl" $DataUrl "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
-									</div>
+									{{$ModalNoText := $.locale.Tr "settings.cancel"}}
+									{{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}}
+									{{template "base/page_dimmer_buttons" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
 								</div>
 							</div>
 						</div>

templates/repo/projects/view.tmpl

@@ -121,7 +121,10 @@
 										{{$.locale.Tr "repo.projects.column.unset_default"}}
 									</a>
 								{{end}}
-								<a class="item show-modal button" data-modal="#delete-board-modal-{{.ID}}">
+								<a class="item show-modal button show-delete-column-modal" 
+									data-modal="#delete-board-modal-{{.ID}}"
+									data-url="{{$.RepoLink}}/projects/{{$.Project.ID}}/{{.ID}}"
+								>
 									{{svg "octicon-trash"}}
 									{{$.locale.Tr "repo.projects.column.delete"}}
 								</a>
@@ -177,12 +180,9 @@
 											{{$.locale.Tr "repo.projects.column.deletion_desc"}}
 										</label>
 									</div>
-									<div class="text right actions">
-										{{$DataUrl := printf "%s/projects/%d/%d" $.RepoLink $.Project.ID .ID}}
-										{{$ModalNoText := $.locale.Tr "settings.cancel"}}
-										{{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}}
-										{{template "base/page_dimmer_buttons" (dict "." $ "ExtendedClasses" "delete-project-board" "DataUrl" $DataUrl "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
-									</div>
+									{{$ModalNoText := $.locale.Tr "settings.cancel"}}
+									{{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}}
+									{{template "base/page_dimmer_buttons" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
 								</div>
 							</div>
 						</div>

web_src/js/features/repo-projects.js

@@ -147,12 +147,16 @@ export function initRepoProject() {
     });
   });
 
-  $('.delete-project-board').each(function () {
-    $(this).click(function (e) {
+  $('.show-delete-column-modal').each(function () {
+    const deleteColumnModal = $(`${$(this).attr('data-modal')}`);
+    const deleteColumnButton = deleteColumnModal.find('.confirm-button');
+    const deleteUrl = $(this).attr('data-url');
+
+    deleteColumnButton.on('click', function (e) {
       e.preventDefault();
 
       $.ajax({
-        url: $(this).data('url'),
+        url: deleteUrl,
         headers: {
           'X-Csrf-Token': csrfToken,
         },
@@ -162,7 +166,7 @@ export function initRepoProject() {
         window.location.reload();
       });
     });
-  });
+  })
 
   $('#new_board_submit').click(function (e) {
     e.preventDefault();