Check if diff actually contains sections when rendering (#9926) (#9933)

lafriks · zeripath · commit f82a8054787e · 2020-01-22T08:02:57.000Z
diff --git a/services/gitdiff/gitdiff.go b/services/gitdiff/gitdiff.go
@@ -344,7 +344,7 @@ func (diffFile *DiffFile) GetHighlightClass() string {
 
 // GetTailSection creates a fake DiffLineSection if the last section is not the end of the file
 func (diffFile *DiffFile) GetTailSection(gitRepo *git.Repository, leftCommitID, rightCommitID string) *DiffSection {
-	if diffFile.Type != DiffFileChange || diffFile.IsBin || diffFile.IsLFSFile {
+	if len(diffFile.Sections) == 0 || diffFile.Type != DiffFileChange || diffFile.IsBin || diffFile.IsLFSFile {
 		return nil
 	}
 	leftCommit, err := gitRepo.GetCommit(leftCommitID)

Original file line number	Diff line number	Diff line change
`@@ -344,7 +344,7 @@ func (diffFile *DiffFile) GetHighlightClass() string {`
`344`	`344`
`345`	`345`	`// GetTailSection creates a fake DiffLineSection if the last section is not the end of the file`
`346`	`346`	`func (diffFile DiffFile) GetTailSection(gitRepo git.Repository, leftCommitID, rightCommitID string) *DiffSection {`
`347`		`- if diffFile.Type != DiffFileChange \|\| diffFile.IsBin \|\| diffFile.IsLFSFile {`
	`347`	`+ if len(diffFile.Sections) == 0 \|\| diffFile.Type != DiffFileChange \|\| diffFile.IsBin \|\| diffFile.IsLFSFile {`
`348`	`348`	`return nil`
`349`	`349`	`}`
`350`	`350`	`leftCommit, err := gitRepo.GetCommit(leftCommitID)`