Skip to content

Commit f79530c

Browse files
authored
Do not use lower tag names to find releases/tags (#29261) (#29262)
Backport #29261. Fix #26090, see #26090 (comment) Since `TagName` stores the original tag name and `LowerTagName` stores the lower tag name, it doesn't make sense to use lowercase tags as `TagNames` in `FindReleasesOptions`. https://github.com/go-gitea/gitea/blob/5e72526da4e915791f03af056890e16821bde052/services/repository/push.go#L396-L397 While the only other usage looks correct: https://github.com/go-gitea/gitea/blob/5e72526da4e915791f03af056890e16821bde052/routers/web/repo/repo.go#L416
1 parent 39735c4 commit f79530c

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

services/repository/push.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -315,12 +315,7 @@ func pushUpdateAddTags(ctx context.Context, repo *repo_model.Repository, gitRepo
315315
return nil
316316
}
317317

318-
lowerTags := make([]string, 0, len(tags))
319-
for _, tag := range tags {
320-
lowerTags = append(lowerTags, strings.ToLower(tag))
321-
}
322-
323-
releases, err := repo_model.GetReleasesByRepoIDAndNames(ctx, repo.ID, lowerTags)
318+
releases, err := repo_model.GetReleasesByRepoIDAndNames(ctx, repo.ID, tags)
324319
if err != nil {
325320
return fmt.Errorf("GetReleasesByRepoIDAndNames: %w", err)
326321
}
@@ -329,6 +324,11 @@ func pushUpdateAddTags(ctx context.Context, repo *repo_model.Repository, gitRepo
329324
relMap[rel.LowerTagName] = rel
330325
}
331326

327+
lowerTags := make([]string, 0, len(tags))
328+
for _, tag := range tags {
329+
lowerTags = append(lowerTags, strings.ToLower(tag))
330+
}
331+
332332
newReleases := make([]*repo_model.Release, 0, len(lowerTags)-len(relMap))
333333

334334
emailToUser := make(map[string]*user_model.User)

0 commit comments

Comments
 (0)