Skip to content

Commit d5cf822

Browse files
committed
fine tune reset token link
1 parent 7acb526 commit d5cf822

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

options/locale/locale_en-US.ini

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3722,6 +3722,7 @@ runners.status.active = Active
37223722
runners.status.offline = Offline
37233723
runners.version = Version
37243724
runners.reset_registration_token = Reset registration token
3725+
runners.reset_registration_token_confirm = Would you like to invalidate the current token and generate a new one?
37253726
runners.reset_registration_token_success = Runner registration token reset successfully
37263727
37273728
runs.all_workflows = All Workflows

routers/web/shared/actions/runners.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,8 @@ func RunnerResetRegistrationToken(ctx *context.Context, ownerID, repoID int64, r
136136
ctx.ServerError("ResetRunnerRegistrationToken", err)
137137
return
138138
}
139-
140139
ctx.Flash.Success(ctx.Tr("actions.runners.reset_registration_token_success"))
141-
ctx.Redirect(redirectTo)
140+
ctx.JSONRedirect(redirectTo)
142141
}
143142

144143
// RunnerDeletePost response for deleting a runner

routers/web/web.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,7 @@ func registerRoutes(m *web.Router) {
463463
m.Combo("/{runnerid}").Get(repo_setting.RunnersEdit).
464464
Post(web.Bind(forms.EditRunnerForm{}), repo_setting.RunnersEditPost)
465465
m.Post("/{runnerid}/delete", repo_setting.RunnerDeletePost)
466-
m.Get("/reset_registration_token", repo_setting.ResetRunnerRegistrationToken)
466+
m.Post("/reset_registration_token", repo_setting.ResetRunnerRegistrationToken)
467467
})
468468
}
469469

templates/shared/actions/runner_list.tmpl

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<h4 class="ui top attached header">
44
{{ctx.Locale.Tr "actions.runners.runner_manage_panel"}} ({{ctx.Locale.Tr "admin.total" .Total}})
55
<div class="ui right">
6-
<div class="ui top right pointing dropdown">
6+
<div class="ui top right pointing dropdown jump">
77
<button class="ui primary tiny button">
88
{{ctx.Locale.Tr "actions.runners.new"}}
99
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
@@ -17,14 +17,18 @@
1717
Registration Token
1818
</div>
1919
<div class="ui input">
20-
<input type="text" value="{{.RegistrationToken}}">
20+
<input type="text" value="{{.RegistrationToken}}" readonly>
2121
<button class="ui basic label button" aria-label="{{ctx.Locale.Tr "copy"}}" data-clipboard-text="{{.RegistrationToken}}">
2222
{{svg "octicon-copy" 14}}
2323
</button>
2424
</div>
2525
<div class="divider"></div>
2626
<div class="item">
27-
<a href="{{$.Link}}/reset_registration_token">{{ctx.Locale.Tr "actions.runners.reset_registration_token"}}</a>
27+
<a class="link-action" data-url="{{$.Link}}/reset_registration_token"
28+
data-modal-confirm="{{ctx.Locale.Tr "actions.runners.reset_registration_token_confirm"}}"
29+
>
30+
{{ctx.Locale.Tr "actions.runners.reset_registration_token"}}
31+
</a>
2832
</div>
2933
</div>
3034
</div>

0 commit comments

Comments
 (0)