Skip to content

Commit c14d3e8

Browse files
fsiddidelvh
andauthored
Remove label color from global issue filters (#22660)
The use of ui colors (red, green, etc) should be limited to actionable or dismissable entries. Before this commit, a green/red label was used to display issues count on each repository. This did not add any meaningful information to the list. Removing the label reduces ambiguity and makes the list easier to scan visually. ![label_compare](https://user-images.githubusercontent.com/451841/215360696-a881b765-207d-4ffa-8bec-398f8e5dab1e.jpg) --------- Co-authored-by: delvh <[email protected]>
1 parent 36dc118 commit c14d3e8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

templates/user/dashboard/issues.tmpl

+2-2
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
<div class="ui divider"></div>
3131
<a class="{{if not $.RepoIDs}}ui basic primary button{{end}} repo name item" href="{{$.Link}}?type={{$.ViewType}}&sort={{$.SortType}}&state={{$.State}}&q={{$.Keyword}}">
3232
<span class="text truncate">All</span>
33-
<div class="ui {{if $.IsShowClosed}}red{{else}}green{{end}} label">{{CountFmt .TotalIssueCount}}</div>
33+
<span class="ui">{{CountFmt .TotalIssueCount}}</span>
3434
</a>
3535
{{range .Repos}}
3636
{{with $Repo := .}}
@@ -49,7 +49,7 @@
4949
{{- end -}}
5050
]&sort={{$.SortType}}&state={{$.State}}&q={{$.Keyword}}" title="{{.FullName}}">
5151
<span class="text truncate">{{$Repo.FullName}}</span>
52-
<div class="ui {{if $.IsShowClosed}}red{{else}}green{{end}} label">{{CountFmt (index $.Counts $Repo.ID)}}</div>
52+
<span class="ui">{{CountFmt (index $.Counts $Repo.ID)}}</span>
5353
</a>
5454
{{end}}
5555
{{end}}

0 commit comments

Comments
 (0)