Skip to content

Commit aff7b7b

Browse files
Remove obsolete CSS text classes (#30576)
- `.text-thin` and `.text-italic` are not present in CSS so were doing nothing and I removed them. - `.text.middle` was unused so I removed it. - `.text.italic` is replaced with `tw-italic`. - `.text.normal` had exactly one use and it wasn't even needed. - add a `muted` class to the link to `org_profile_avatar.tmpl`. --------- Co-authored-by: wxiaoguang <[email protected]>
1 parent 0386a42 commit aff7b7b

File tree

9 files changed

+11
-27
lines changed

9 files changed

+11
-27
lines changed

templates/org/team/members.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
</div>
4747
{{else}}
4848
<div class="flex-item">
49-
<span class="text grey italic">{{ctx.Locale.Tr "org.teams.members.none"}}</span>
49+
<span class="text grey tw-italic">{{ctx.Locale.Tr "org.teams.members.none"}}</span>
5050
</div>
5151
{{end}}
5252
</div>

templates/org/team/repositories.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
</div>
4949
{{else}}
5050
<div class="flex-item">
51-
<span class="text grey italic">{{ctx.Locale.Tr "org.teams.repos.none"}}</span>
51+
<span class="text grey tw-italic">{{ctx.Locale.Tr "org.teams.repos.none"}}</span>
5252
</div>
5353
{{end}}
5454
</div>

templates/org/team/sidebar.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
{{if .Team.Description}}
2323
{{.Team.Description}}
2424
{{else}}
25-
<span class="text grey italic">{{ctx.Locale.Tr "org.teams.no_desc"}}</span>
25+
<span class="text grey tw-italic">{{ctx.Locale.Tr "org.teams.no_desc"}}</span>
2626
{{end}}
2727
</div>
2828
{{if eq .Team.LowerName "owners"}}

templates/repo/create.tmpl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
</div>
6666
<div class="inline field">
6767
<label>{{ctx.Locale.Tr "repo.template"}}</label>
68-
<div id="repo_template_search" class="ui search normal selection dropdown">
68+
<div id="repo_template_search" class="ui search selection dropdown">
6969
<input type="hidden" id="repo_template" name="repo_template" value="{{.repo_template}}">
7070
<div class="default text">{{.repo_template_name}}</div>
7171
<div class="menu">
@@ -119,7 +119,7 @@
119119
<div id="non_template">
120120
<div class="inline field">
121121
<label>{{ctx.Locale.Tr "repo.issue_labels"}}</label>
122-
<div class="ui search normal selection dropdown">
122+
<div class="ui search selection dropdown">
123123
<input type="hidden" name="issue_labels" value="{{.issueLabels}}">
124124
<div class="default text">{{ctx.Locale.Tr "repo.issue_labels_helper"}}</div>
125125
<div class="menu">
@@ -135,7 +135,7 @@
135135

136136
<div class="inline field">
137137
<label>.gitignore</label>
138-
<div class="ui multiple search normal selection dropdown">
138+
<div class="ui multiple search selection dropdown">
139139
<input type="hidden" name="gitignores" value="{{.gitignores}}">
140140
<div class="default text">{{ctx.Locale.Tr "repo.repo_gitignore_helper"}}</div>
141141
<div class="menu">

templates/repo/file_info.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div class="file-info text grey normal tw-font-mono">
1+
<div class="file-info tw-font-mono">
22
{{if .FileIsSymlink}}
33
<div class="file-info-entry">
44
{{ctx.Locale.Tr "repo.symbolic_link"}}

templates/repo/settings/collaboration.tmpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
</div>
3030
</div>
3131
</div>
32-
<button class="ui red tiny button inline text-thin delete-button" data-url="{{$.Link}}/delete" data-id="{{.ID}}">
32+
<button class="ui red tiny button inline delete-button" data-url="{{$.Link}}/delete" data-id="{{.ID}}">
3333
{{ctx.Locale.Tr "repo.settings.delete_collaborator"}}
3434
</button>
3535
</div>
@@ -75,7 +75,7 @@
7575
</div>
7676
{{if $allowedToChangeTeams}}
7777
<div class="flex-item-trailing" {{if .IncludesAllRepositories}} data-tooltip-content="{{ctx.Locale.Tr "repo.settings.delete_team_tip"}}"{{end}}>
78-
<button class="ui red tiny button inline text-thin delete-button {{if .IncludesAllRepositories}}disabled{{end}}" data-url="{{$.Link}}/team/delete" data-id="{{.ID}}">
78+
<button class="ui red tiny button inline delete-button {{if .IncludesAllRepositories}}disabled{{end}}" data-url="{{$.Link}}/team/delete" data-id="{{.ID}}">
7979
{{ctx.Locale.Tr "repo.settings.delete_collaborator"}}
8080
</button>
8181
</div>

templates/repo/settings/options.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@
135135
<form method="post" class="tw-inline-block">
136136
{{.CsrfTokenHtml}}
137137
<input type="hidden" name="action" value="mirror-sync">
138-
<button class="ui primary tiny button inline text-thin">{{ctx.Locale.Tr "repo.settings.sync_mirror"}}</button>
138+
<button class="ui primary tiny button inline">{{ctx.Locale.Tr "repo.settings.sync_mirror"}}</button>
139139
</form>
140140
</td>
141141
</tr>

templates/shared/user/org_profile_avatar.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<div class="column">
55
<div class="ui header tw-flex tw-items-center gt-word-break">
66
{{ctx.AvatarUtils.Avatar . 100}}
7-
<span class="text thin grey"><a href="{{.HomeLink}}">{{.DisplayName}}</a></span>
7+
<span class="text grey"><a class="muted" href="{{.HomeLink}}">{{.DisplayName}}</a></span>
88
<span class="org-visibility">
99
{{if .Visibility.IsLimited}}<div class="ui medium basic horizontal label">{{ctx.Locale.Tr "org.settings.visibility.limited_shortname"}}</div>{{end}}
1010
{{if .Visibility.IsPrivate}}<div class="ui medium basic horizontal label">{{ctx.Locale.Tr "org.settings.visibility.private_shortname"}}</div>{{end}}

web_src/css/base.css

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -702,29 +702,13 @@ input:-webkit-autofill:active,
702702
text-align: right !important;
703703
}
704704

705-
.ui .text.normal {
706-
font-weight: var(--font-weight-normal);
707-
}
708-
709-
.ui .text.italic {
710-
font-style: italic;
711-
}
712-
713705
.ui .text.truncate {
714706
overflow-x: hidden;
715707
text-overflow: ellipsis;
716708
white-space: nowrap;
717709
display: inline-block;
718710
}
719711

720-
.ui .text.thin {
721-
font-weight: var(--font-weight-normal);
722-
}
723-
724-
.ui .text.middle {
725-
vertical-align: middle;
726-
}
727-
728712
.ui .message.flash-message {
729713
text-align: center;
730714
}

0 commit comments

Comments
 (0)