Display error when adding a user to a team twice (#4746)

Author: adelowo

options/locale/locale_en-US.ini

@@ -1312,6 +1312,7 @@ teams.search_repo_placeholder = Search repository…
 teams.add_team_repository = Add Team Repository
 teams.remove_repo = Remove
 teams.add_nonexistent_repo = "The repository you're trying to add does not exist; please create it first."
+teams.add_duplicate_users = User is already a team member.
 
 [admin]
 dashboard = Dashboard

routers/org/teams.go

@@ -96,7 +96,12 @@ func TeamsAction(ctx *context.Context) {
 			return
 		}
 
-		err = ctx.Org.Team.AddMember(u.ID)
+		if ctx.Org.Team.IsMember(u.ID) {
+			ctx.Flash.Error(ctx.Tr("org.teams.add_duplicate_users"))
+		} else {
+			err = ctx.Org.Team.AddMember(u.ID)
+		}
+
 		page = "team"
 	}