Skip to content

Commit 93f8157

Browse files
committed
Fix release lower tag name updating
1 parent b2a9ea0 commit 93f8157

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

models/release.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ func createTag(gitRepo *git.Repository, rel *Release) error {
140140
}
141141
return err
142142
}
143+
rel.LowerTagName = strings.ToLower(rel.TagName)
143144
}
144145
commit, err := gitRepo.GetTagCommit(rel.TagName)
145146
if err != nil {
@@ -427,9 +428,7 @@ func DeleteReleaseByID(id int64, u *User, delTag bool) error {
427428
func SyncReleasesWithTags(repo *Repository, gitRepo *git.Repository) error {
428429
existingRelTags := make(map[string]struct{})
429430
opts := FindReleasesOptions{IncludeDrafts: true, IncludeTags: true}
430-
page := 0
431-
for {
432-
page++
431+
for page := 1; ; page++ {
433432
rels, err := GetReleasesByRepoID(repo.ID, opts, page, 100)
434433
if err != nil {
435434
return fmt.Errorf("GetReleasesByRepoID: %v", err)

models/update.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ func pushUpdateAddTag(repo *Repository, gitRepo *git.Repository, tagName string)
136136
RepoID: repo.ID,
137137
Title: "",
138138
TagName: tagName,
139+
LowerTagName: strings.ToLower(tagName),
139140
Target: "",
140141
Sha1: commit.ID.String(),
141142
NumCommits: commitsCount,
@@ -156,6 +157,7 @@ func pushUpdateAddTag(repo *Repository, gitRepo *git.Repository, tagName string)
156157
rel.Sha1 = commit.ID.String()
157158
rel.CreatedUnix = tagCreatedUnix
158159
rel.NumCommits = commitsCount
160+
rel.IsDraft = false
159161
if rel.IsTag && author != nil {
160162
rel.PublisherID = author.ID
161163
}

0 commit comments

Comments
 (0)