Fix data-race bug when accessing task.LastRun (#27584) (#27586)

GiteaBot · wxiaoguang · web-flow · commit 844ab9a4416b · 2023-10-11T15:27:38.000Z
Backport #27584 by @wxiaoguang Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
diff --git a/services/cron/cron.go b/services/cron/cron.go
@@ -107,12 +107,11 @@ func ListTasks() TaskTable {
 			prev = e.PreviousRun()
 		}
 
+		task.lock.Lock()
 		// If the manual run is after the cron run, use that instead.
 		if prev.Before(task.LastRun) {
 			prev = task.LastRun
 		}
-
-		task.lock.Lock()
 		tTable = append(tTable, &TaskTableRow{
 			Name:        task.Name,
 			Spec:        spec,

Original file line number	Diff line number	Diff line change
`@@ -107,12 +107,11 @@ func ListTasks() TaskTable {`
`107`	`107`	`prev = e.PreviousRun()`
`108`	`108`	`}`
`109`	`109`
	`110`	`+ task.lock.Lock()`
`110`	`111`	`// If the manual run is after the cron run, use that instead.`
`111`	`112`	`if prev.Before(task.LastRun) {`
`112`	`113`	`prev = task.LastRun`
`113`	`114`	`}`
`114`		`-`
`115`		`- task.lock.Lock()`
`116`	`115`	`tTable = append(tTable, &TaskTableRow{`
`117`	`116`	`Name: task.Name,`
`118`	`117`	`Spec: spec,`