Don't send notification on pending reviews (#8943)

guillep2k · zeripath · commit 8282f2625095 · 2019-11-13T18:36:04.000Z
diff --git a/services/pull/review.go b/services/pull/review.go
@@ -17,7 +17,9 @@ func CreateReview(opts models.CreateReviewOptions) (*models.Review, error) {
 		return nil, err
 	}
 
-	notification.NotifyPullRequestReview(review.Issue.PullRequest, review, nil)
+	if opts.Type != models.ReviewTypePending {
+		notification.NotifyPullRequestReview(review.Issue.PullRequest, review, nil)
+	}
 
 	return review, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,9 @@ func CreateReview(opts models.CreateReviewOptions) (*models.Review, error) {`
`17`	`17`	`return nil, err`
`18`	`18`	`}`
`19`	`19`
`20`		`- notification.NotifyPullRequestReview(review.Issue.PullRequest, review, nil)`
	`20`	`+ if opts.Type != models.ReviewTypePending {`
	`21`	`+ notification.NotifyPullRequestReview(review.Issue.PullRequest, review, nil)`
	`22`	`+ }`
`21`	`23`
`22`	`24`	`return review, nil`
`23`	`25`	`}`