Use TruncateString

Author: JakobDev

modules/util/string.go

@@ -95,12 +95,3 @@ func UnsafeBytesToString(b []byte) string {
 func UnsafeStringToBytes(s string) []byte {
 	return unsafe.Slice(unsafe.StringData(s), len(s))
 }
-
-// GetFirstCharacters returns the first n characters of a string
-func GetFirstCharacters(s string, n int) string {
-	r := []rune(s)
-	if len(s) <= n {
-		return string(r[:n])
-	}
-	return s[:n]
-}

modules/util/string_test.go

@@ -45,9 +45,3 @@ func TestToSnakeCase(t *testing.T) {
 		assert.Equal(t, expected, ToSnakeCase(input))
 	}
 }
-
-func TestGetFirstCharacters(t *testing.T) {
-	assert.Equal(t, "Test123", GetFirstCharacters("Test123", 10))
-	assert.Equal(t, "Test", GetFirstCharacters("Test123", 4))
-	assert.Equal(t, "こん", GetFirstCharacters("こんにちは", 2))
-}

services/migrations/gitea_uploader.go

@@ -19,6 +19,7 @@ import (
 	issues_model "code.gitea.io/gitea/models/issues"
 	repo_model "code.gitea.io/gitea/models/repo"
 	user_model "code.gitea.io/gitea/models/user"
+	base_module "code.gitea.io/gitea/modules/base"
 	"code.gitea.io/gitea/modules/git"
 	"code.gitea.io/gitea/modules/label"
 	"code.gitea.io/gitea/modules/log"
@@ -397,7 +398,7 @@ func (g *GiteaLocalUploader) CreateIssues(issues ...*base.Issue) error {
 			RepoID:      g.repo.ID,
 			Repo:        g.repo,
 			Index:       issue.Number,
-			Title:       util.GetFirstCharacters(issue.Title, 255),
+			Title:       base_module.TruncateString(issue.Title, 255),
 			Content:     issue.Content,
 			Ref:         issue.Ref,
 			IsClosed:    issue.State == "closed",