Skip to content

Commit 7a0a789

Browse files
committed
if a table is already using utf8mb4, do not convert it again.
1 parent dca09f8 commit 7a0a789

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

models/db/convert.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ package db
66
import (
77
"fmt"
88
"strconv"
9+
"strings"
910

1011
"code.gitea.io/gitea/modules/log"
1112
"code.gitea.io/gitea/modules/setting"
@@ -34,6 +35,10 @@ func ConvertUtf8ToUtf8mb4() error {
3435
return err
3536
}
3637

38+
if strings.HasPrefix(table.Collation, "utf8mb4") {
39+
fmt.Printf("skip table %q because it is already using utf8mb4\n", table.Name)
40+
continue
41+
}
3742
if _, err := x.Exec(fmt.Sprintf("ALTER TABLE `%s` CONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci;", table.Name)); err != nil {
3843
return err
3944
}

0 commit comments

Comments
 (0)