Skip to content

Commit 6cf07ce

Browse files
add some tests.
1 parent 1c45dc2 commit 6cf07ce

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

modules/packages/arch/metadata.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ var (
4545
// https://man.archlinux.org/man/PKGBUILD.5
4646
namePattern = regexp.MustCompile(`\A[a-zA-Z0-9@._+-]+\z`)
4747
// (epoch:pkgver-pkgrel)
48-
versionPattern = regexp.MustCompile(`\A(?:[\d]:)?[\w.+~]+(?:-[-\w.+~]+)?\z`)
48+
versionPattern = regexp.MustCompile(`\A(?:\d:)?[\w.+~]+(?:-[-\w.+~]+)?\z`)
4949
)
5050

5151
type Package struct {

modules/packages/arch/metadata_test.go

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import (
77
"archive/tar"
88
"bytes"
99
"compress/gzip"
10+
"fmt"
1011
"io"
1112
"testing"
1213

@@ -122,13 +123,14 @@ func TestParsePackageInfo(t *testing.T) {
122123
assert.ErrorIs(t, err, ErrInvalidName)
123124
})
124125

125-
t.Run("InvalidVersion", func(t *testing.T) {
126-
data := createPKGINFOContent(packageName, "")
127-
128-
p, err := ParsePackageInfo(bytes.NewReader(data))
129-
assert.Nil(t, p)
130-
assert.ErrorIs(t, err, ErrInvalidVersion)
131-
})
126+
for _, v := range []string{"", "a:1.0.0-1", "0.0.1/1-1", "1.0.0 -1"} {
127+
t.Run(fmt.Sprintf("InvalidVersion[%s]", v), func(t *testing.T) {
128+
data := createPKGINFOContent(packageName, v)
129+
p, err := ParsePackageInfo(bytes.NewReader(data))
130+
assert.Nil(t, p)
131+
assert.ErrorIs(t, err, ErrInvalidVersion)
132+
})
133+
}
132134

133135
t.Run("Valid", func(t *testing.T) {
134136
data := createPKGINFOContent(packageName, packageVersion)

0 commit comments

Comments
 (0)