Add note about ignored errors

Author: lafriks

models/migrations/v45.go

@@ -18,6 +18,7 @@ func removeIndexColumnFromRepoUnitTable(x *xorm.Engine) (err error) {
 		log.Warn("Unable to drop columns in SQLite")
 	case setting.UseMySQL, setting.UsePostgreSQL, setting.UseMSSQL, setting.UseTiDB:
 		if _, err := x.Exec("ALTER TABLE repo_unit DROP COLUMN `index`"); err != nil {
+			// Ignoring this error in case we run this migration second time (after migration reordeting)
 			return fmt.Errorf("DROP COLUMN index: %v", err)
 		}
 	default:

models/migrations/v50.go

@@ -44,6 +44,7 @@ func migrateProtectedBranchStruct(x *xorm.Engine) error {
 		log.Warn("Unable to drop columns in SQLite")
 	case setting.UseMySQL, setting.UsePostgreSQL, setting.UseMSSQL, setting.UseTiDB:
 		if _, err := x.Exec("ALTER TABLE protected_branch DROP COLUMN can_push"); err != nil {
+			// Ignoring this error in case we run this migration second time (after migration reordeting)
 			log.Warn("DROP COLUMN can_push: %v", err)
 		}
 	default:

models/migrations/v51.go

@@ -34,6 +34,7 @@ func addDefaultValueToUserProhibitLogin(x *xorm.Engine) (err error) {
 	}
 
 	if err != nil {
+		// Ignoring this error in case we run this migration second time (after migration reordeting)
 		log.Warn("Error changing user prohibit_login column definition: %v", err)
 	}