Fix review request notification issue link when external issue tracker is enabled (#13723)

jpraet · web-flow · commit 48c9865fce91 · 2020-11-28T13:06:59.000+02:00
The issue.HTMLURL() automatically gets converted to the expected #issue format by the post processors
diff --git a/modules/notification/mail/mail.go b/modules/notification/mail/mail.go
@@ -104,7 +104,7 @@ func (m *mailNotifier) NotifyIssueChangeAssignee(doer *models.User, issue *model
 
 func (m *mailNotifier) NotifyPullReviewRequest(doer *models.User, issue *models.Issue, reviewer *models.User, isRequest bool, comment *models.Comment) {
 	if isRequest && doer.ID != reviewer.ID && reviewer.EmailNotifications() == models.EmailNotificationsEnabled {
-		ct := fmt.Sprintf("Requested to review #%d.", issue.Index)
+		ct := fmt.Sprintf("Requested to review %s.", issue.HTMLURL())
 		mailer.SendIssueAssignedMail(issue, doer, ct, comment, []string{reviewer.Email})
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ func (m mailNotifier) NotifyIssueChangeAssignee(doer models.User, issue *model`
`104`	`104`
`105`	`105`	`func (m mailNotifier) NotifyPullReviewRequest(doer models.User, issue models.Issue, reviewer models.User, isRequest bool, comment *models.Comment) {`
`106`	`106`	`if isRequest && doer.ID != reviewer.ID && reviewer.EmailNotifications() == models.EmailNotificationsEnabled {`
`107`		`- ct := fmt.Sprintf("Requested to review #%d.", issue.Index)`
	`107`	`+ ct := fmt.Sprintf("Requested to review %s.", issue.HTMLURL())`
`108`	`108`	`mailer.SendIssueAssignedMail(issue, doer, ct, comment, []string{reviewer.Email})`
`109`	`109`	`}`
`110`	`110`	`}`