Skip to content

Commit 1f47ccf

Browse files
committed
Avoid sending "0 new commits" webhook
Signed-off-by: Till Faelligen <[email protected]>
1 parent 8d08195 commit 1f47ccf

File tree

7 files changed

+28
-0
lines changed

7 files changed

+28
-0
lines changed

modules/webhook/dingtalk.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,10 @@ func getDingtalkForkPayload(p *api.ForkPayload) (*DingtalkPayload, error) {
8383
}
8484

8585
func getDingtalkPushPayload(p *api.PushPayload) (*DingtalkPayload, error) {
86+
if len(p.Commits) == 0 {
87+
return nil, fmt.Errorf("no commits in payload")
88+
}
89+
8690
var (
8791
branchName = git.RefEndName(p.Ref)
8892
commitDesc string

modules/webhook/discord.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,10 @@ func getDiscordForkPayload(p *api.ForkPayload, meta *DiscordMeta) (*DiscordPaylo
177177
}
178178

179179
func getDiscordPushPayload(p *api.PushPayload, meta *DiscordMeta) (*DiscordPayload, error) {
180+
if len(p.Commits) == 0 {
181+
return nil, fmt.Errorf("no commits in payload")
182+
}
183+
180184
var (
181185
branchName = git.RefEndName(p.Ref)
182186
commitDesc string

modules/webhook/feishu.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,10 @@ func getFeishuForkPayload(p *api.ForkPayload) (*FeishuPayload, error) {
6666
}
6767

6868
func getFeishuPushPayload(p *api.PushPayload) (*FeishuPayload, error) {
69+
if len(p.Commits) == 0 {
70+
return nil, fmt.Errorf("no commits in payload")
71+
}
72+
6973
var (
7074
branchName = git.RefEndName(p.Ref)
7175
commitDesc string

modules/webhook/matrix.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,10 @@ func getMatrixReleasePayload(p *api.ReleasePayload, matrix *MatrixMeta) (*Matrix
145145
}
146146

147147
func getMatrixPushPayload(p *api.PushPayload, matrix *MatrixMeta) (*MatrixPayloadUnsafe, error) {
148+
if len(p.Commits) == 0 {
149+
return nil, fmt.Errorf("no commits in payload")
150+
}
151+
148152
var commitDesc string
149153

150154
if len(p.Commits) == 1 {

modules/webhook/msteams.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,10 @@ func getMSTeamsForkPayload(p *api.ForkPayload) (*MSTeamsPayload, error) {
196196
}
197197

198198
func getMSTeamsPushPayload(p *api.PushPayload) (*MSTeamsPayload, error) {
199+
if len(p.Commits) == 0 {
200+
return nil, fmt.Errorf("no commits in payload")
201+
}
202+
199203
var (
200204
branchName = git.RefEndName(p.Ref)
201205
commitDesc string

modules/webhook/slack.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,10 @@ func getSlackReleasePayload(p *api.ReleasePayload, slack *SlackMeta) (*SlackPayl
189189
}
190190

191191
func getSlackPushPayload(p *api.PushPayload, slack *SlackMeta) (*SlackPayload, error) {
192+
if len(p.Commits) == 0 {
193+
return nil, fmt.Errorf("no commits in payload")
194+
}
195+
192196
// n new commits
193197
var (
194198
commitDesc string

modules/webhook/telegram.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,10 @@ func getTelegramForkPayload(p *api.ForkPayload) (*TelegramPayload, error) {
8686
}
8787

8888
func getTelegramPushPayload(p *api.PushPayload) (*TelegramPayload, error) {
89+
if len(p.Commits) == 0 {
90+
return nil, fmt.Errorf("no commits in payload")
91+
}
92+
8993
var (
9094
branchName = git.RefEndName(p.Ref)
9195
commitDesc string

0 commit comments

Comments
 (0)