check whether parsedWorkflows[0].Job() is nil

Author: wxiaoguang

models/actions/run_job.go

@@ -100,17 +100,21 @@ func (job *ActionRunJob) LoadAttributes(ctx context.Context) error {
 	return job.Run.LoadAttributes(ctx)
 }
 
-// Load the job structure from the ActionRunJob
+// ParseJob parses the job structure from the ActionRunJob.WorkflowPayload
 func (job *ActionRunJob) ParseJob() (*jobparser.Job, error) {
-	// singleWorkflows is created from an ActionJob, which always contains exactly a single job's YAML definition.
+	// job.WorkflowPayload is a SingleWorkflow created from an ActionRun's workflow, which exactly contains this job's YAML definition.
 	// Ideally it shouldn't be called "Workflow", it is just a job with global workflow fields + trigger
 	parsedWorkflows, err := jobparser.Parse(job.WorkflowPayload)
 	if err != nil {
-		return nil, fmt.Errorf("parse workflow of job %d: %w", job.ID, err)
+		return nil, fmt.Errorf("job %d single workflow: unable to parse: %w", job.ID, err)
 	} else if len(parsedWorkflows) != 1 {
-		return nil, fmt.Errorf("workflow of job %d: not single workflow", job.ID)
+		return nil, fmt.Errorf("job %d single workflow: not single workflow", job.ID)
 	}
 	_, workflowJob := parsedWorkflows[0].Job()
+	if workflowJob == nil {
+		// it shouldn't happen, and since the callers don't check nil, so return an error instead of nil
+		return nil, util.ErrorWrap(util.ErrNotExist, "job %d single workflow: payload doesn't contain a job", job.JobID)
+	}
 	return workflowJob, nil
 }