Skip to content

Commit 079ef56

Browse files
authored
Fix permission check on issue/pull lock (#22113)
backport #22110
1 parent b54c064 commit 079ef56

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

routers/web/web.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -626,7 +626,6 @@ func RegisterRoutes(m *web.Route) {
626626
reqRepoReleaseWriter := context.RequireRepoWriter(unit.TypeReleases)
627627
reqRepoReleaseReader := context.RequireRepoReader(unit.TypeReleases)
628628
reqRepoWikiWriter := context.RequireRepoWriter(unit.TypeWiki)
629-
reqRepoIssueWriter := context.RequireRepoWriter(unit.TypeIssues)
630629
reqRepoIssueReader := context.RequireRepoReader(unit.TypeIssues)
631630
reqRepoPullsReader := context.RequireRepoReader(unit.TypePullRequests)
632631
reqRepoIssuesOrPullsWriter := context.RequireRepoWriterOr(unit.TypeIssues, unit.TypePullRequests)
@@ -947,8 +946,8 @@ func RegisterRoutes(m *web.Route) {
947946
})
948947
})
949948
m.Post("/reactions/{action}", bindIgnErr(forms.ReactionForm{}), repo.ChangeIssueReaction)
950-
m.Post("/lock", reqRepoIssueWriter, bindIgnErr(forms.IssueLockForm{}), repo.LockIssue)
951-
m.Post("/unlock", reqRepoIssueWriter, repo.UnlockIssue)
949+
m.Post("/lock", reqRepoIssuesOrPullsWriter, bindIgnErr(forms.IssueLockForm{}), repo.LockIssue)
950+
m.Post("/unlock", reqRepoIssuesOrPullsWriter, repo.UnlockIssue)
952951
m.Post("/delete", reqRepoAdmin, repo.DeleteIssue)
953952
}, context.RepoMustNotBeArchived())
954953
m.Group("/{index}", func() {

0 commit comments

Comments
 (0)