Make the toggle-escape-button really a button

Author: Mai-Lapyst

modules/markup/html.go

@@ -1217,11 +1217,10 @@ func filePreviewPatternProcessor(ctx *RenderContext, node *html.Node) {
 
 					escapeBtn := &html.Node{
 						Type: html.ElementNode,
-						Data: atom.A.String(),
+						Data: atom.Button.String(),
 						Attr: []html.Attribute{
 							{Key: "class", Val: "toggle-escape-button btn interact-bg"},
 							{Key: "title", Val: btnTitle},
-							{Key: "href", Val: "javascript:void(0)"},
 						},
 					}
 					tdLinesEscape.AppendChild(escapeBtn)

modules/markup/sanitizer.go

@@ -131,7 +131,9 @@ func createDefaultPolicy() *bluemonday.Policy {
 	policy.AllowAttrs("rel").Matching(regexp.MustCompile("^L[0-9]+$")).OnElements("td")
 	policy.AllowAttrs("class").Matching(regexp.MustCompile("^file-preview*")).OnElements("table")
 	policy.AllowAttrs("class").Matching(regexp.MustCompile("^lines-escape$")).OnElements("td")
-	policy.AllowAttrs("class").Matching(regexp.MustCompile("^toggle-escape-button btn interact-bg$")).OnElements("a")
+	policy.AllowAttrs("class").Matching(regexp.MustCompile("^toggle-escape-button btn interact-bg$")).OnElements("button")
+	policy.AllowAttrs("title").OnElements("button")
+	policy.AllowAttrs()
 	policy.AllowAttrs("class").Matching(regexp.MustCompile("^ambiguous-code-point$")).OnElements("span")
 	policy.AllowAttrs("data-tooltip-content").OnElements("span")
 	policy.AllowAttrs("class").Matching(regexp.MustCompile("muted|(text black)")).OnElements("a")