Skip to content
This repository was archived by the owner on Apr 12, 2019. It is now read-only.

ask git version from 1.7.10 to 1.8.1.6 since git log command needs #48

Merged
merged 1 commit into from
Apr 26, 2017
Merged

ask git version from 1.7.10 to 1.8.1.6 since git log command needs #48

merged 1 commit into from
Apr 26, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 20, 2017

@appleboy
Copy link
Member

LGTM

@appleboy
Copy link
Member

let L-G-T-M work

@strk
Copy link
Member

strk commented Apr 20, 2017

What makes 1.8.1.5 not work, exactly ?

@lunny
Copy link
Member Author

lunny commented Apr 20, 2017

Yes, the minimal git version is 1.8.1.6

@strk
Copy link
Member

strk commented Apr 20, 2017

My question was: why ? Do you have a reference to a CHANGELOG entry showing that 1.8.1.6 (and not just 1.8) introduced a new feature we need here ?

@lunny
Copy link
Member Author

lunny commented Apr 20, 2017

@strk we have used git log in this repository but not clarify the git version. Then I find the minimal version requirement for git log is 1.8.1.6 in the URL I mentioned above. So I sent this PR. This is not a new feature, it's a missing requirement.

@strk
Copy link
Member

strk commented Apr 20, 2017

git log was introduced by git/git@215a7ad in 2005 - even v0.99.7a had that commit...

@cez81
Copy link

cez81 commented Apr 20, 2017

@lunny Did you look at versions found at https://git-scm.com/docs/git-log? Even if 1.8.1.6 is the first version listed, it's not when command was introduced. I have done that mistake myself...

@sapk
Copy link
Member

sapk commented Apr 26, 2017

https://github.com/git/git/blob/master/Documentation/RelNotes/1.7.9.txt allready talk about git log command. I think that 1.8.1.6 is the first version with full documentation.

@sapk
Copy link
Member

sapk commented Apr 26, 2017

In light of the release date of 1.8.1.6 (more than 5 years) and packages version in common distribution. I give this PR my LGTM. It's not a bad thing to ask for "newer version" that limit possible incompatibility.

@strk
Copy link
Member

strk commented Apr 26, 2017 via email

@lunny lunny merged commit 3f99247 into go-gitea:master Apr 26, 2017
@lunny lunny deleted the lunny/fix_release_git_version branch April 26, 2017 13:12
@strk
Copy link
Member

strk commented Oct 18, 2017

@sapk I just had problems with that meaningless strong dependency. Gogs run just fine on a Debian 6 but Hitea cannot, because it wants git 1.8 for no reason... I think this PR should be reverted

@tboerger
Copy link
Member

Debian 6 is EOL since more than a year, so why should we care about that? It's not our problem if you are running such outdated systems...

@lunny
Copy link
Member Author

lunny commented Oct 19, 2017

Even Debian 6 could use backports to upgrade to git 1.9. I also use Debian 6 on my instance. High git version for security and performance. I don't think an too old version git support is needed.

@strk
Copy link
Member

strk commented Oct 19, 2017 via email

@strk
Copy link
Member

strk commented Nov 13, 2017

Further discussion about this topic moved to #90

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Releases page don't show anything if git version less than 1.8
6 participants