-
Notifications
You must be signed in to change notification settings - Fork 38
ask git version from 1.7.10 to 1.8.1.6 since git log command needs #48
Conversation
LGTM |
let L-G-T-M work |
What makes 1.8.1.5 not work, exactly ? |
Yes, the minimal git version is 1.8.1.6 |
My question was: why ? Do you have a reference to a CHANGELOG entry showing that 1.8.1.6 (and not just |
@strk we have used |
|
@lunny Did you look at versions found at https://git-scm.com/docs/git-log? Even if 1.8.1.6 is the first version listed, it's not when command was introduced. I have done that mistake myself... |
https://github.com/git/git/blob/master/Documentation/RelNotes/1.7.9.txt allready talk about |
In light of the release date of 1.8.1.6 (more than 5 years) and packages version in common distribution. I give this PR my LGTM. It's not a bad thing to ask for "newer version" that limit possible incompatibility. |
I just find it weird to request a patch-level detailed version.
1.7+ would be enough for me, unless it's proved wrong.
|
@sapk I just had problems with that meaningless strong dependency. Gogs run just fine on a Debian 6 but Hitea cannot, because it wants git 1.8 for no reason... I think this PR should be reverted |
Debian 6 is EOL since more than a year, so why should we care about that? It's not our problem if you are running such outdated systems... |
Even Debian 6 could use backports to upgrade to git 1.9. I also use |
I hadn't found backports of git 1.9 for Debian 6, did you ?
We shouldn't make decisions for users, if a git version is too
old for our taste it isn't necessarely so for others.
Let's just not put arbitrary obstacles on the way to use Gitea, shall we ?
|
Further discussion about this topic moved to #90 |
see https://git-scm.com/docs/git-log/1.8.1.6 and this will fix go-gitea/gitea#1133