Skip to content
This repository was archived by the owner on Apr 12, 2019. It is now read-only.

Add tests for RunInDirTimeoutPipeline #42

Merged
merged 1 commit into from
Apr 8, 2017
Merged

Add tests for RunInDirTimeoutPipeline #42

merged 1 commit into from
Apr 8, 2017

Conversation

typeless
Copy link

@typeless typeless commented Apr 8, 2017 •
edited
Loading

For #41

Caveats:

  1. The tests are only run when -race enabled
  2. The test for 'no timeout happening scenario' takes long time to run, about 13 seconds for 1000 repetitions on my laptop.
  3. The testing loops might not be necessary. Under the -race enabled, the race get positive in the first round for TestRunInDirTimeoutPipelineAlwaysTimeout.

@typeless typeless force-pushed the test-command-timeout branch from 749ea3b to a550bdc Compare April 8, 2017 04:17
lunny
lunny suggested changes Apr 8, 2017
View reviewed changes
command_test.go Outdated
@@ -0,0 +1,43 @@
// Copyright 2015 The Gogs Authors. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong copyright name and year

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@lunny
Copy link
Member

lunny commented Apr 8, 2017

Otherwise LGTM

@typeless typeless force-pushed the test-command-timeout branch from a550bdc to f453b38 Compare April 8, 2017 05:28
@appleboy
Copy link
Member

appleboy commented Apr 8, 2017

LGTM

@appleboy appleboy merged commit d5e562c into go-gitea:master Apr 8, 2017
@typeless typeless deleted the test-command-timeout branch April 8, 2017 05:32
@typeless typeless mentioned this pull request Apr 8, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny requested changes

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
kind/testing lgtm/done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@typeless @lunny @appleboy @tboerger